Skip to content

Remove unused code#371

Open
CapacitorSet wants to merge 4 commits intohoneytrap:masterfrom
CapacitorSet:feature-remove-unused
Open

Remove unused code#371
CapacitorSet wants to merge 4 commits intohoneytrap:masterfrom
CapacitorSet:feature-remove-unused

Conversation

@CapacitorSet
Copy link
Contributor

This is a copy of #316, for which I had accidentally not used a feature branch.

@codecov-io
Copy link

codecov-io commented Jul 8, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@674ac4f). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #371   +/-   ##
=========================================
  Coverage          ?   43.58%           
=========================================
  Files             ?       71           
  Lines             ?     8333           
  Branches          ?        0           
=========================================
  Hits              ?     3632           
  Misses            ?     4285           
  Partials          ?      416
Impacted Files Coverage Δ
server/honeytrap.go 3.26% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 674ac4f...84c3e19. Read the comment docs.

@martijnjanssen
Copy link
Contributor

There is also a bunch of commented lines in the services.go. I'm pretty sure that can also go, it was added in the initial commit, but it's never used again.

@CapacitorSet
Copy link
Contributor Author

Indeed, I noticed that, but I think it's groundwork for future developments. Pinging @nl5887 for feedback.

@CapacitorSet CapacitorSet force-pushed the feature-remove-unused branch from 0fc5fe8 to 84c3e19 Compare July 10, 2018 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants