-
Notifications
You must be signed in to change notification settings - Fork 174
Fix WithConfig instances #407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=========================================
Coverage ? 41.69%
=========================================
Files ? 78
Lines ? 8792
Branches ? 0
=========================================
Hits ? 3666
Misses ? 4701
Partials ? 425
Continue to review full report at Codecov.
|
Waiting for feedback if issue has been resolved? |
@sammynx could you verify? |
Yes, I'm waiting for confirmation that they're actually unused (so that I know it's not a bug in WithConfig). |
The warning is correct, the values are unused. This is the issue. However when I tested this pull, the warning is gone for me. So it's hiding a problem now. |
That's weird, this doesn't happen for me with a simple config (single port, single service, |
I don't know how my config looked anymore, because I changed it a lot recently. I was working on this issue with smtp. There must have been a mixup with configs, because I can't recreate my issues from last comment. Situation now: on a build from this PR I get no warnings. So this is working for me now. Sorry for the confusion I made in earlier comments. This is the config I used for this.
|
Thank you for your feedback. This PR is ready for merging, then. |
Merged, thanks! |
Discovered while fixing #402.
Not yet ready for merging, I'm waiting for feedback on the issue.