Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions regarding actor_network #16

Closed
Damoners opened this issue Aug 10, 2020 · 1 comment
Closed

Questions regarding actor_network #16

Damoners opened this issue Aug 10, 2020 · 1 comment

Comments

@Damoners
Copy link

Hello, after reading the code, I have some questions about the details of the actor_network, if these questions can be answered, I will not be very grateful :)

  1. In the part of the node network, why are there three dimensions in the input vector shape of the network instead of the two dimensions of [batch_size, number of features] in the usual design, so what are the considerations and basis for designing the input vector?
  2. In the part of the node network, the features of input vectors combine the output of GCN and "node_inputs". Why is "node_inputs" also merged? Isn't the former a high-level representation of the latter processed by GCN?
@hongzimao
Copy link
Owner

  1. Notice that different jobs may have different number of nodes (computation stages). We can't simply merge features from two jobs into a 2D matrix because of size mismatch. However, the 3D input will be reshape to 2D in the pipeline (after the message passing step in graph neural network). Keep in mind we need to keep track of which row in the 2D features corresponding to which job from the 3D input. If you are interested, we implement the reshape operation (for sparse features) in https://github.com/hongzimao/decima-sim/blob/c010dd74ff4b7566bd0ac989c90a32cfbc630d84/sparse_op.py (you can trace how these functions are used in the feature processing pipeline)

  2. We include the original feature because global level aggregation may find it more straightforward to use (e.g., sum the total work of all nodes). Feel free to leave out the merge and see if it affects the performance. It will be interesting to know.

@Damoners Damoners closed this as completed Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants