From 38b95f0c38f46303e7b091e56a70a515a8c4706c Mon Sep 17 00:00:00 2001 From: Hong Zhiguo Date: Tue, 28 Feb 2017 16:02:10 +0800 Subject: [PATCH] fix LeaderTransitions always zero on leader transition, LeaderTransitions is increased to 1, but then cleared to zero by next renew. External monitoring system may watch LeaderTransitions and rely on it's facticity. --- pkg/client/leaderelection/leaderelection.go | 1 + 1 file changed, 1 insertion(+) diff --git a/pkg/client/leaderelection/leaderelection.go b/pkg/client/leaderelection/leaderelection.go index ac6530161d11..6119c9b5fee7 100644 --- a/pkg/client/leaderelection/leaderelection.go +++ b/pkg/client/leaderelection/leaderelection.go @@ -253,6 +253,7 @@ func (le *LeaderElector) tryAcquireOrRenew() bool { // here. Let's correct it before updating. if oldLeaderElectionRecord.HolderIdentity == le.config.Lock.Identity() { leaderElectionRecord.AcquireTime = oldLeaderElectionRecord.AcquireTime + leaderElectionRecord.LeaderTransitions = oldLeaderElectionRecord.LeaderTransitions } else { leaderElectionRecord.LeaderTransitions = oldLeaderElectionRecord.LeaderTransitions + 1 }