Repository navigation
fix(jwt): reject a signature segment outside the base64url alphabet and a header with crit - #5597
Merged
Merged
Conversation
…nd a header with crit
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
HTTP Performance Benchmark
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5597 +/- ##
==========================================
- Coverage 80.31% 80.15% -0.17%
==========================================
Files 149 150 +1
Lines 10529 10565 +36
Branches 2358 2353 -5
==========================================
+ Hits 8456 8468 +12
- Misses 2073 2097 +24 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
verify()accepted a signature segment that contains characters outside the base64url alphabet, such as trailing whitespace, because the decoder ignored them. Several different token strings therefore verified as the same token. The signature segment is now checked against the base64url alphabet before decoding, and such tokens are rejected withJwtTokenInvalid.It also rejects a header with
crit. Hono implements no JWS extensions, so anycritmust be rejected (RFC 7515, 4.1.11).Reported by @harshit-d3v.
The author should do the following, if applicable
pnpm run check:fixto format and lint the code