New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stops runtime error in IE6+ #1

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@coldclimate

coldclimate commented May 11, 2012

Hi,
I kept getting runtime errors with IE6 (and 8) until i switched the p for a div. Not tested hard.

@honza

This comment has been minimized.

Show comment
Hide comment
@honza

honza May 11, 2012

Owner

See, the <div/> element is a general purpose HTML element that can hold anything in it. This is in sharp contrast to the paragraph tag which is only meant to be used for copy text that will actually be displayed.

While I certainly appreciate your effort to fix this framework in IE, I don't think this is the right approach.

Owner

honza commented May 11, 2012

See, the <div/> element is a general purpose HTML element that can hold anything in it. This is in sharp contrast to the paragraph tag which is only meant to be used for copy text that will actually be displayed.

While I certainly appreciate your effort to fix this framework in IE, I don't think this is the right approach.

@honza honza closed this May 11, 2012

@coldclimate

This comment has been minimized.

Show comment
Hide comment
@coldclimate

coldclimate May 11, 2012

No worries - I'm not big into IE support but needed to make it work (if not in a nice way).

coldclimate commented May 11, 2012

No worries - I'm not big into IE support but needed to make it work (if not in a nice way).

@honza

This comment has been minimized.

Show comment
Hide comment
@honza

honza May 11, 2012

Owner

As Kenneth Reitz would say, "It came out 11 years ago. That's older than Youtube. Upgrade."

Owner

honza commented May 11, 2012

As Kenneth Reitz would say, "It came out 11 years ago. That's older than Youtube. Upgrade."

@coldclimate

This comment has been minimized.

Show comment
Hide comment
@coldclimate

coldclimate May 11, 2012

I wish I could in this case. Developing things other people run on their domains is a PITA.

coldclimate commented May 11, 2012

I wish I could in this case. Developing things other people run on their domains is a PITA.

@coldclimate

This comment has been minimized.

Show comment
Hide comment
@coldclimate

coldclimate May 11, 2012

(oh and thanks for the reference I've been trying to dig that up for months)

coldclimate commented May 11, 2012

(oh and thanks for the reference I've been trying to dig that up for months)

@honza

This comment has been minimized.

Show comment
Hide comment
@honza

honza May 11, 2012

Owner

Haha, here is where I happened first.

requests/requests#351 (comment)

Owner

honza commented May 11, 2012

Haha, here is where I happened first.

requests/requests#351 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment