Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Stops runtime error in IE6+ #1

Closed
wants to merge 1 commit into from

2 participants

@coldclimate

Hi,
I kept getting runtime errors with IE6 (and 8) until i switched the p for a div. Not tested hard.

@honza
Owner

See, the <div/> element is a general purpose HTML element that can hold anything in it. This is in sharp contrast to the paragraph tag which is only meant to be used for copy text that will actually be displayed.

While I certainly appreciate your effort to fix this framework in IE, I don't think this is the right approach.

@honza honza closed this
@coldclimate

No worries - I'm not big into IE support but needed to make it work (if not in a nice way).

@honza
Owner

As Kenneth Reitz would say, "It came out 11 years ago. That's older than Youtube. Upgrade."

@coldclimate

I wish I could in this case. Developing things other people run on their domains is a PITA.

@coldclimate

(oh and thanks for the reference I've been trying to dig that up for months)

@honza
Owner

Haha, here is where I happened first.

kennethreitz/requests#351 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 11, 2012
  1. swithcing p to div for better IE support

    coldclimate authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  140medley.js
View
2  140medley.js
@@ -158,7 +158,7 @@ var m = function(
c // placeholder
){
b = document; // get the document,
- c = b.createElement("p"); // create a container element,
+ c = b.createElement("div"); // create a container element,
c.innerHTML = a; // write the HTML to it, and
a = b.createDocumentFragment(); // create a fragment.
Something went wrong with that request. Please try again.