Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support calendar properties #15

Merged
merged 1 commit into from Feb 25, 2020
Merged

Conversation

hadronzoo
Copy link
Contributor

Adds the following properties:

  • name
  • description
  • timezone
  • ttl

Adds:
- name
- description
- timezone
- ttl
@hadronzoo
Copy link
Contributor Author

Added this to make calendar titles work with Apple Calendar.

@strohel
Copy link
Contributor

strohel commented Feb 24, 2020

I cannot approve, but this looks good. I was actually about to add support for these myself, I have the same need.

@strohel
Copy link
Contributor

strohel commented Feb 24, 2020

Given usefulness of this, a Changelog entry could be worth it.

@hoodie hoodie merged commit ce18c4c into hoodie:master Feb 25, 2020
@hoodie
Copy link
Owner

hoodie commented Feb 25, 2020

Thank you @hadronzoo for the contribution. I took the liberty to add conventional commit prefixes to your commits to be able to generate the changelog.

@hadronzoo
Copy link
Contributor Author

@hoodie I apologize for the late reply. Thank you for merging!

@hadronzoo hadronzoo deleted the feature/calendar-name branch February 27, 2020 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants