Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Ignore the assets folder from being published to npm #196

Merged
merged 1 commit into from Mar 21, 2018
Merged

chore: Ignore the assets folder from being published to npm #196

merged 1 commit into from Mar 21, 2018

Conversation

anshumanv
Copy link
Contributor

Fixes #144

.gitignore Outdated
@@ -41,3 +41,6 @@ private-key.pem
#nyc test coverage
.nyc_output
coverage

# prevent the assets folder to be published
assets
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will ignore the assets folder altogether, not only for publish to npm. You either have to put it to .npmignore or you define a specific list of files / folders that you want to be published as described at https://docs.npmjs.com/files/package.json#files, which is what I’d prefer. Here is an example: https://github.com/octokit/rest.js/blob/master/package.json#L110-L115

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I misunderstood the issue, made the changes, please see if this is appropriate. 👍

Thanks for the example though. :)

@anshumanv anshumanv changed the title chore: Ignore the assets folder to be published to npm chore: Ignore the assets folder from being published to npm Mar 21, 2018
Copy link
Contributor

@gr2m gr2m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good :)

@gr2m gr2m merged commit 55828b1 into first-timers:master Mar 21, 2018
@anshumanv anshumanv deleted the 144 branch March 21, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants