fix: connection upsert with only destination config flags now works #175
+256
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added destinationURL and destinationCliPath to hasAnyDestinationFlag() check - Added destinationURL and destinationCliPath to hasDestinationConfigOnly check - Added destinationURL and destinationCliPath to hasDestinationConfigUpdate check - Added destinationCliPath handling in buildDestinationInputForUpdate() - Added comprehensive test suite for partial updates (TestConnectionUpsertPartialUpdates) This fixes the 422 error when running: hookdeck connection upsert <name> --destination-url <URL> Previously, the CLI wasn't detecting that destination config flags were provided, so it didn't fetch the existing connection to preserve source/destination references. The API requires both source and destination in every PUT request, so the CLI now automatically handles this by fetching the existing connection and merging changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the 422 error when running:
hookdeck connection upsert --destination-url
Previously, the CLI wasn't detecting that destination config flags were provided,
so it didn't fetch the existing connection to preserve source/destination references.
The API requires both source and destination in every PUT request, so the CLI now
automatically handles this by fetching the existing connection and merging changes.