From edd19844758963c697df38b2261ca5422a3bb603 Mon Sep 17 00:00:00 2001 From: Alex Luong Date: Thu, 9 Oct 2025 01:56:49 +0700 Subject: [PATCH 1/3] chore: streamline Claude GitHub Actions workflow Remove automatic PR review workflow in favor of on-demand reviews via @claude mentions. Add CLAUDE.md with project context and code review guidelines. Grant pull-requests write permission to enable structured reviews with gh pr review. --- .github/workflows/claude-code-review.yml | 57 ------------------------ .github/workflows/claude.yml | 2 +- CLAUDE.md | 15 +++++++ 3 files changed, 16 insertions(+), 58 deletions(-) delete mode 100644 .github/workflows/claude-code-review.yml create mode 100644 CLAUDE.md diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml deleted file mode 100644 index 205b0fe2..00000000 --- a/.github/workflows/claude-code-review.yml +++ /dev/null @@ -1,57 +0,0 @@ -name: Claude Code Review - -on: - pull_request: - types: [opened, synchronize] - # Optional: Only run on specific file changes - # paths: - # - "src/**/*.ts" - # - "src/**/*.tsx" - # - "src/**/*.js" - # - "src/**/*.jsx" - -jobs: - claude-review: - # Optional: Filter by PR author - # if: | - # github.event.pull_request.user.login == 'external-contributor' || - # github.event.pull_request.user.login == 'new-developer' || - # github.event.pull_request.author_association == 'FIRST_TIME_CONTRIBUTOR' - - runs-on: ubuntu-latest - permissions: - contents: read - pull-requests: read - issues: read - id-token: write - - steps: - - name: Checkout repository - uses: actions/checkout@v4 - with: - fetch-depth: 1 - - - name: Run Claude Code Review - id: claude-review - uses: anthropics/claude-code-action@v1 - with: - claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} - prompt: | - REPO: ${{ github.repository }} - PR NUMBER: ${{ github.event.pull_request.number }} - - Please review this pull request and provide feedback on: - - Code quality and best practices - - Potential bugs or issues - - Performance considerations - - Security concerns - - Test coverage - - Use the repository's CLAUDE.md for guidance on style and conventions. Be constructive and helpful in your feedback. - - Use `gh pr comment` with your Bash tool to leave your review as a comment on the PR. - - # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md - # or https://docs.claude.com/en/docs/claude-code/cli-reference for available options - claude_args: '--allowed-tools "Bash(gh issue view:*),Bash(gh search:*),Bash(gh issue list:*),Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*)"' - diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml index 412cef9e..ade69c89 100644 --- a/.github/workflows/claude.yml +++ b/.github/workflows/claude.yml @@ -20,7 +20,7 @@ jobs: runs-on: ubuntu-latest permissions: contents: read - pull-requests: read + pull-requests: write issues: read id-token: write actions: read # Required for Claude to read CI results on PRs diff --git a/CLAUDE.md b/CLAUDE.md new file mode 100644 index 00000000..17ecbb62 --- /dev/null +++ b/CLAUDE.md @@ -0,0 +1,15 @@ +# Claude Instructions for Outpost + +Outpost is open-source infrastructure for managing and delivering platform events to webhooks, AWS SQS, RabbitMQ, and more. + +## Code Review + +When reviewing pull requests: +- Use `gh pr review` to submit structured reviews with inline comments on specific lines +- Provide feedback on: + - Code quality and best practices + - Potential bugs or issues + - Performance considerations + - Security concerns + - Test coverage +- Be constructive and helpful in your feedback From 425d680e5ae2342630d351a01e350bce120f6c55 Mon Sep 17 00:00:00 2001 From: Alex Luong Date: Thu, 9 Oct 2025 02:08:03 +0700 Subject: [PATCH 2/3] fix: enhance Claude workflow permission Add track_progress for visual review updates, enable inline PR comments via MCP tool, and expand permissions to support comprehensive code reviews and issue management. --- .github/workflows/claude.yml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml index ade69c89..bbd45736 100644 --- a/.github/workflows/claude.yml +++ b/.github/workflows/claude.yml @@ -21,7 +21,7 @@ jobs: permissions: contents: read pull-requests: write - issues: read + issues: write id-token: write actions: read # Required for Claude to read CI results on PRs steps: @@ -35,6 +35,7 @@ jobs: uses: anthropics/claude-code-action@v1 with: claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} + track_progress: true # This is an optional setting that allows Claude to read CI results on PRs additional_permissions: | @@ -46,5 +47,5 @@ jobs: # Optional: Add claude_args to customize behavior and configuration # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md # or https://docs.claude.com/en/docs/claude-code/cli-reference for available options - # claude_args: '--allowed-tools Bash(gh pr:*)' + claude_args: '--allowed-tools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr review:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*),Bash(gh issue view:*),Bash(gh issue list:*)"' From 854c150e8974478cac2bd3826dbb9588056b09eb Mon Sep 17 00:00:00 2001 From: Alex Luong Date: Thu, 9 Oct 2025 02:37:26 +0700 Subject: [PATCH 3/3] chore: remove `gh pr` mention in prompt --- .github/workflows/claude.yml | 5 +++-- CLAUDE.md | 17 ++++++++--------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/claude.yml b/.github/workflows/claude.yml index bbd45736..6878c864 100644 --- a/.github/workflows/claude.yml +++ b/.github/workflows/claude.yml @@ -35,6 +35,7 @@ jobs: uses: anthropics/claude-code-action@v1 with: claude_code_oauth_token: ${{ secrets.CLAUDE_CODE_OAUTH_TOKEN }} + track_progress: true # This is an optional setting that allows Claude to read CI results on PRs @@ -47,5 +48,5 @@ jobs: # Optional: Add claude_args to customize behavior and configuration # See https://github.com/anthropics/claude-code-action/blob/main/docs/usage.md # or https://docs.claude.com/en/docs/claude-code/cli-reference for available options - claude_args: '--allowed-tools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr review:*),Bash(gh pr diff:*),Bash(gh pr view:*),Bash(gh pr list:*),Bash(gh issue view:*),Bash(gh issue list:*)"' - + claude_args: | + --allowedTools "mcp__github_inline_comment__create_inline_comment,Bash(gh pr comment:*),Bash(gh pr diff:*),Bash(gh pr view:*)" diff --git a/CLAUDE.md b/CLAUDE.md index 17ecbb62..5d3e237b 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -4,12 +4,11 @@ Outpost is open-source infrastructure for managing and delivering platform event ## Code Review -When reviewing pull requests: -- Use `gh pr review` to submit structured reviews with inline comments on specific lines -- Provide feedback on: - - Code quality and best practices - - Potential bugs or issues - - Performance considerations - - Security concerns - - Test coverage -- Be constructive and helpful in your feedback +When reviewing pull requests, provide feedback on: +- Code quality and best practices +- Potential bugs or issues +- Performance considerations +- Security concerns +- Test coverage + +Be constructive and helpful in your feedback.