From e9a0258334a9214d404b34386a903b16b416def8 Mon Sep 17 00:00:00 2001 From: Alex Luong Date: Wed, 6 May 2026 21:37:40 +0700 Subject: [PATCH 1/2] fix: correct misleading ID prefix field descriptions The desc tags for AttemptPrefix, DestinationPrefix, and EventPrefix incorrectly stated the prefix is "prepended with underscore". The prefix is actually used as-is (verified by idgen tests). Updated descriptions to clarify this behavior. Co-Authored-By: Claude Opus 4.6 (1M context) --- internal/config/id_gen.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/config/id_gen.go b/internal/config/id_gen.go index a35c001db..c2e2b6c78 100644 --- a/internal/config/id_gen.go +++ b/internal/config/id_gen.go @@ -3,7 +3,7 @@ package config // IDGenConfig is the configuration for ID generation type IDGenConfig struct { Type string `yaml:"type" env:"IDGEN_TYPE" desc:"ID generation type for all entities: uuidv4, uuidv7, nanoid. Default: uuidv4" required:"N"` - AttemptPrefix string `yaml:"attempt_prefix" env:"IDGEN_ATTEMPT_PREFIX" desc:"Prefix for attempt IDs, prepended with underscore (e.g., 'atm_123'). Default: empty (no prefix)" required:"N"` - DestinationPrefix string `yaml:"destination_prefix" env:"IDGEN_DESTINATION_PREFIX" desc:"Prefix for destination IDs, prepended with underscore (e.g., 'dst_123'). Default: empty (no prefix)" required:"N"` - EventPrefix string `yaml:"event_prefix" env:"IDGEN_EVENT_PREFIX" desc:"Prefix for event IDs, prepended with underscore (e.g., 'evt_123'). Default: empty (no prefix)" required:"N"` + AttemptPrefix string `yaml:"attempt_prefix" env:"IDGEN_ATTEMPT_PREFIX" desc:"Prefix for attempt IDs, used as-is (e.g., 'atm_' produces 'atm_'). Default: empty (no prefix)" required:"N"` + DestinationPrefix string `yaml:"destination_prefix" env:"IDGEN_DESTINATION_PREFIX" desc:"Prefix for destination IDs, used as-is (e.g., 'dst_' produces 'dst_'). Default: empty (no prefix)" required:"N"` + EventPrefix string `yaml:"event_prefix" env:"IDGEN_EVENT_PREFIX" desc:"Prefix for event IDs, used as-is (e.g., 'evt_' produces 'evt_'). Default: empty (no prefix)" required:"N"` } From 41ad7e765892771285e73ee2965c61d56a51ff2e Mon Sep 17 00:00:00 2001 From: Alex Luong Date: Thu, 7 May 2026 02:14:20 +0700 Subject: [PATCH 2/2] fix: clarify prefix descriptions and use cloud example Co-Authored-By: Claude Opus 4.7 (1M context) --- internal/config/id_gen.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/config/id_gen.go b/internal/config/id_gen.go index c2e2b6c78..c8a08a38c 100644 --- a/internal/config/id_gen.go +++ b/internal/config/id_gen.go @@ -3,7 +3,7 @@ package config // IDGenConfig is the configuration for ID generation type IDGenConfig struct { Type string `yaml:"type" env:"IDGEN_TYPE" desc:"ID generation type for all entities: uuidv4, uuidv7, nanoid. Default: uuidv4" required:"N"` - AttemptPrefix string `yaml:"attempt_prefix" env:"IDGEN_ATTEMPT_PREFIX" desc:"Prefix for attempt IDs, used as-is (e.g., 'atm_' produces 'atm_'). Default: empty (no prefix)" required:"N"` - DestinationPrefix string `yaml:"destination_prefix" env:"IDGEN_DESTINATION_PREFIX" desc:"Prefix for destination IDs, used as-is (e.g., 'dst_' produces 'dst_'). Default: empty (no prefix)" required:"N"` - EventPrefix string `yaml:"event_prefix" env:"IDGEN_EVENT_PREFIX" desc:"Prefix for event IDs, used as-is (e.g., 'evt_' produces 'evt_'). Default: empty (no prefix)" required:"N"` + AttemptPrefix string `yaml:"attempt_prefix" env:"IDGEN_ATTEMPT_PREFIX" desc:"Prefix for attempt IDs, prepended without modification (e.g., 'atm_' produces 'atm_'). Default: empty (no prefix)" required:"N"` + DestinationPrefix string `yaml:"destination_prefix" env:"IDGEN_DESTINATION_PREFIX" desc:"Prefix for destination IDs, prepended without modification (e.g., 'des_' produces 'des_'). Default: empty (no prefix)" required:"N"` + EventPrefix string `yaml:"event_prefix" env:"IDGEN_EVENT_PREFIX" desc:"Prefix for event IDs, prepended without modification (e.g., 'evt_' produces 'evt_'). Default: empty (no prefix)" required:"N"` }