Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix oauth first-time bug #22

Closed
creationix opened this Issue Mar 28, 2013 · 5 comments

Comments

Projects
None yet
2 participants
Contributor

creationix commented Mar 28, 2013

The first time a github oauth token is granted the postMessage never makes it to the parent page.

@ghost ghost assigned creationix Mar 28, 2013

@ghost
Contributor

ghost commented Mar 28, 2013

Seeing this behavior for all attempted logins = can't get past the login screen. Closed tab, re-opened, CMD+R, login, see the popup, no error, no login.

Not working in Chrome Canary either.

Contributor

creationix commented Mar 28, 2013

Changed the oauth flow to not use a popup window and instead use full-page redirects.

To test any page other than the / route you need to specify the HOME_URL environment variable.

For example, to test oauth with /testfinder.html you need to start the server like:

HOME_URL=/testfinder.html node server.js

and then point the browser to http://localhost:8080/testfinder.html

@creationix creationix closed this Mar 28, 2013

@ghost
Contributor

ghost commented Mar 28, 2013

The demo page still pops a page, but now it loads the login page in the popup. When I click login inside the popup it seems to reload same page = can't log in.

Contributor

creationix commented Mar 29, 2013

I guess I shouldn't have closed this till it was integrated with the real
front-end and pushed to the live server.

On Thu, Mar 28, 2013 at 6:20 PM, Open Peer notifications@github.com wrote:

The demo page still pops a page, but now it loads the login page in the
popup. When I click login inside the popup it seems to reload same page =
can't log in.


Reply to this email directly or view it on GitHubhttps://github.com/openpeer/opjs/issues/22#issuecomment-15621257
.

@ghost
Contributor

ghost commented Mar 29, 2013

Ah yea, just figured that was done, my bad. Turning QA knob off for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment