Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web UI: linkify links from room names #42

Closed
ge0rg opened this issue Oct 7, 2019 · 1 comment · Fixed by #50
Closed

Web UI: linkify links from room names #42

ge0rg opened this issue Oct 7, 2019 · 1 comment · Fixed by #50
Labels
component:web enhancement

Comments

@ge0rg
Copy link

@ge0rg ge0rg commented Oct 7, 2019

When a room name / subject / description contains links, it would be great to have them linkified in the browser.

This is also a very nice security test case ;-)
@horazont horazont added component:web enhancement labels Oct 7, 2019
@horazont
Copy link
Owner

@horazont horazont commented Oct 7, 2019 •
edited

I’m still not sure whether I want this. Folks, vote for this issue with reactions.

Some constraints:

  • URLs in the room name will never be linkified – it already is a link, and nesting another link in there would be very confusing (and clickjacky).
  • Links will be tagged with rel="nofollow" to detract spammers.

horazont added a commit that referenced this issue Feb 1, 2020
@horazont
Implement linkification in description texts
f064154 
Fixes #42.
@horazont horazont mentioned this issue Feb 1, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component:web enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement linkification in description texts horazont/muchopper
2 participants
@ge0rg @horazont