fix(Core): correct SessionStorageBackend namespace in SessionHandlerFactory#133
Merged
Merged
Conversation
…actory The use statement imported Horde\SessionHandler\Storage\SessionStorageBackend, but the interface lives in Horde\SessionHandler. PHP's autoload silently failed to resolve the wrong-namespaced reference, causing the createHashtableBackend() return type to be unresolvable at runtime — every call with hashtable/memcache session driver threw TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
usestatement importedHorde\SessionHandler\Storage\SessionStorageBackend, but the interface actually lives inHorde\SessionHandler(noStoragesegment).PHP's autoload silently failed to resolve the wrong-namespaced reference, which meant
createHashtableBackend()'s: SessionStorageBackendreturn type couldn't be checked at runtime. Result: every call withcache.driver = 'hashtable'or'memcache'for sessions threw a misleadingTypeError:HashtableBackenddoes implementSessionStorageBackend— the type check just couldn't see it because the imported name pointed nowhere.SessionHandlerFactoryTestalready exercised this and was failing with 5 errors. After the one-line fix, all 13 tests pass.Refs #131