Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: decouple composer installation from pear #3

Closed
wants to merge 16 commits into from

Conversation

@ralflang
Copy link
Member

@ralflang ralflang commented Feb 6, 2019

https://wiki.horde.org/Project/NoMorePear
Generate composer json file from .horde.yml

components/lib/Helper/Composer.php currently depends on conductor and gets its data from package.xml

(For the moment, add each component's git repo as a source - for production, we would want packagist instead)

},
"suggest": {
"pear-pear.horde.org/Horde_Test": "*",
"horde/Test": "*",
"pear-pear.php.net/Archive_Tar": "*",

You could/should use pear/archive_tar instead of pear-pear.php.net/Archive_Tar.

This uses the much quicker installation as composer package AND will also work, if pear.php.net is down, as it is currently.

Ralf

Copy link
Member Author

@ralflang ralflang Feb 10, 2019

You're right. The current composer.json generator does not yet handle third party requirements. It's on the list ;)

@ralflang
Copy link
Member Author

@ralflang ralflang commented Jul 28, 2020

TODO:

  • Update fork to current base horde.
  • Change the default release pipeline from hardcoded to configurable (with a default that doesn't need the config file)
  • Style, phpdoc, Horde Coding Standards

lib/Components/Component/Source.php Outdated Show resolved Hide resolved
lib/Components/Component/Source.php Outdated Show resolved Hide resolved
ralflang added 14 commits Jul 29, 2020
Render composer file from .horde.yml
Do not depend on package.xml file from pear
This is probably no longer required as other parts of the code just skip
pre-pear versions. However I doubt it hurts.
Minor changes to existing Changelog/Package tasks

New tasks or factored out from the hard-wired release pipeline
- Unit Test
- Satis Repo Trigger
- GitBranch
- GitPush
- Composer
Fall back to hard-wired release pipeline

Also, fix another legacy dependency on pear package.xml

TODO: Move the hard-wired pipeline into the "upstream" pipeline which
comes either from config or from builtin defaults
@yunosh
Copy link
Member

@yunosh yunosh commented Feb 18, 2021

Is this superceded by #4 and can be closed, or is it still WIP?

@ralflang
Copy link
Member Author

@ralflang ralflang commented Feb 18, 2021

Both are conflicting. I will close this one. I have been working the night/until the morning on refreshing #4 so it incorporates the latest accepted changes/features as of yesterday.

@ralflang ralflang closed this Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants