Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Global Tagging #182

Closed
dearmond opened this issue Mar 25, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@dearmond
Copy link

commented Mar 25, 2019

This is a Feature Proposal

Description

For feature proposals:

  • Global tags declared in Serverless should propagate to step functions as well.

Global defined like so:

provider:
  name: aws
  tags:
    foo: bar
    baz: qux

Similar or dependent issues:

  • #166 Added tagging (awesome!) but not global tagging.

Additional Data

  • Serverless Framework Core Version you're using: 1.39.1
  • The Plugin Version you're using: 1.15.0
  • Operating System: macOS
@theburningmonk

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

This is a great idea!

@theburningmonk theburningmonk self-assigned this Mar 25, 2019

@theburningmonk

This comment has been minimized.

Copy link
Collaborator

commented Mar 25, 2019

@dearmond actually this already works, but only on a fresh deploy (not sure if that's a CloudFormation thing). For example, I have a serverless.yml where I set the stackTags:
image

and when it's deployed, the state machine inherits the team tag as well
image

@theburningmonk theburningmonk removed their assignment Mar 25, 2019

@dearmond

This comment has been minimized.

Copy link
Author

commented Mar 25, 2019

That's why Serverless has another global tags setting, so it can be applied on serverless deploy.

@theburningmonk

This comment has been minimized.

Copy link
Collaborator

commented Mar 26, 2019

🎉 This issue has been resolved in version 1.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.