Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Full Transaction Info #398

Closed
7 of 9 tasks
esengulov opened this issue Dec 14, 2018 · 3 comments
Closed
7 of 9 tasks

Implement Full Transaction Info #398

esengulov opened this issue Dec 14, 2018 · 3 comments
Assignees
Labels
Projects

Comments

@esengulov
Copy link
Member

esengulov commented Dec 14, 2018

  • full tx info design
  • should have light and dark mode
  • add block explorer "Source" selection controller (see designs in comments, on Jan 18)
  • "Data Provider": should open data source selection controller (design attached below, on January 18'th).
  • if the given API provides the FEE(in fiat) only in USD, then show that for all currencies. Only the horyzontalsystems.xyz will have values for all currencies.
  • for Ethereum blockchain we want extra fields (Gas price, Gas used, Gas limit). These blockchain specific terms should be hardcoded, we will not localize them.
  • if the API doesn't provide data for an item (ex: tx size) then show "..." instead of the value.
  • integrate the following APIs as the data providers for "blockchain explorers"
  • the Share button should be sharing the website link to that transaction on that public block explorer.
    -- if I am sharing with someone transaction than I am basically sending a link to that transaction on selected block explorer.
    -- test the feature with WhatsApp, Telegram and Facebook messenger.
    -- On successful share the user should return back to transaction info. successful share should display "confirmation" checkmark/alert.

##Blockchain Explorers

BTC

-http://btc.horizontalsystems.xyz (default)

-https://btc.com (https://btc.com/api-doc#General 
 (no access keys, supposedly no restrictions)
-https://blockexplorer.com/api-ref
 (no access keys, supposedly no restrictions)
-https://blockchair.com
 (no access keys, supposedly no restrictions)
-//IPFS(coming soon, do not add it now)



BCH
-http://bch.horizontalsystems.xyz (default)
-https://blockchair.com
 (no access keys, supposedly no restrictions)
-//IPFS(coming soon, do not add it now)


ETH
-http://eth.horizontalsystems.xyz (default)
-https://blockchair.com
 (no access keys, supposedly no restrictions)
-https://etherscan.io/apis
 (the free key on this API restricted to 5 calls/second. As an option we can ask the user to obtain his own free key(https://etherscan.io/myapikey) and use it. That would require an additional step on our end where user will be asked to add the API Key.
-//IPFS(coming soon, do not add it now)

@abdrasulov abdrasulov added this to To do in 0.2 Dec 25, 2018
@tmedetbekov tmedetbekov moved this from To do to In progress in 0.2 Dec 25, 2018
@esengulov
Copy link
Member Author

@tmedetbekov note the updated tasks list in description

@esengulov
Copy link
Member Author

esengulov commented Jan 18, 2019

@tmedetbekov reopened the issue as the feature isn't fully implemented yet

@TalgatNurdinov upload the slightly updated designs here:

  • source selection for block explorer
  • updated design for full transaction info

@esengulov esengulov reopened this Jan 18, 2019
0.2 automation moved this from Done to In progress Jan 18, 2019
@TalgatNurdinov
Copy link
Member

screen shot 2019-01-18 at 11 56 32 am

https://app.zeplin.io/project/5b18ecff68e34a92986b0224/dashboard?seid=5b90faef4e79f19ceb4f2dbc

https://app.zeplin.io/project/5b18ecff68e34a92986b0224/dashboard?seid=5b90faef4e79f19ceb4f2dbc

screen shot 2019-01-18 at 12 05 45 pm

https://zpl.io/VxRPyYg

for ETH
screen shot 2019-01-18 at 12 06 40 pm

0.2 automation moved this from In progress to Done Jan 23, 2019
@Dianaaiym Dianaaiym moved this from Done to Accepted in 0.2 Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
0.2
  
Accepted
Development

No branches or pull requests

3 participants