Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC 20 Token support #141

Closed
8 tasks done
esengulov opened this issue Nov 16, 2018 · 1 comment · Fixed by #454
Closed
8 tasks done

ERC 20 Token support #141

esengulov opened this issue Nov 16, 2018 · 1 comment · Fixed by #454
Assignees
@ant013
Labels
feature New feature
Projects
Version 0.2

Comments

@esengulov
Copy link
Member

esengulov commented Nov 16, 2018 •
edited by mNizhurin

  • after coin manager is ready
  • Use the ERC20.json file from IPFS (the copy of the file available in one of HS repositories), as a source for the erc20 icons and other token parameters. Refer to the note below.
  • sync with the source file once a day
  • when a coin is removed from the IPFS source file but that same coin is active for some users then the coin should be available to those users, until is disabled.
  • Support svg files for coin icons
  • when user tries to transfer ERC20 coin but there is not enough ETH balance to pay the fee an alert should be shown. @Dianaaiym will provide the key value for the localization string
  • Show fee in ETH
  • Support rate for ETH fee

Note: For each ERC20 contract there is:

  • "coin symbol": "BNB",
  • "coin name": "Binance Coin",
  • "decimal count"
  • "contract address": "0xB8c77482e45F1F44dE1745F52C74426C631bDD52"

Once the wallet knows the contract address it may get relevant icons for the coin from IPFS

ERC20 source file location:

https://ipfs.horizontalsystems.xyz/ipns/Qmd4Gv2YVPqs6dmSy1XEq7pQRSgLihqYKL2JjK7DMUFPVz/io-hs/data/blockchain/ETH/erc20

JSON file :
https://ipfs.horizontalsystems.xyz/ipns/Qmd4Gv2YVPqs6dmSy1XEq7pQRSgLihqYKL2JjK7DMUFPVz/io-hs/data/blockchain/ETH/erc20/index.json
@esengulov esengulov added the feature New feature label Nov 16, 2018
@esengulov esengulov added this to To Do in Version 0.2 Nov 26, 2018
@esengulov esengulov removed this from To Do in Version 0.2 Dec 6, 2018
@esengulov esengulov added this to To do in Version 0.3 via automation Dec 6, 2018
@esengulov esengulov removed this from To do in Version 0.3 Dec 14, 2018
@esengulov esengulov added this to To Do in Version 0.2 via automation Dec 14, 2018
This was referenced Jan 18, 2019
Closed
Closed
@esengulov esengulov changed the title ERC 20 support ERC 20 Token support Jan 18, 2019
@ant013 ant013 moved this from To Do to In Progress in Version 0.2 Jan 22, 2019
This was referenced Feb 3, 2019
Closed
Closed
@Dianaaiym
Copy link
Member

Use this key for alert "send_erc.alert"

ealymbaev added a commit that referenced this issue Feb 4, 2019
@ealymbaev
Merge pull request #397 from horizontalsystems/erc_alert_change_text
bdba957 
ERC 20 Alert: Change Text (#141)
@ant013 ant013 moved this from In Progress to Done in Version 0.2 Feb 4, 2019
@ant013 ant013 moved this from Done to In Progress in Version 0.2 Feb 4, 2019
ant013 added a commit that referenced this issue Feb 4, 2019
@ant013
Add erc20 token support using coin manager. Step #1 (#141)
06c023c 
- Add adapters for ethereum and erc20
- Make base adapter with same functions for ethereum'coins
- Deinit kit when no ethereum coins visible
- Move ethereum key to config provider
- Fix ui bug with transaction cell, when tx comes in first block and waiting icon don't changes right to time
- update ethereum pod
ealymbaev added a commit that referenced this issue Feb 4, 2019
@ealymbaev
Merge pull request #400 from horizontalsystems/add_erc20_support
380fc99 
Add erc20 token support using coin manager. Step #1 (#141)
ealymbaev added a commit that referenced this issue Feb 5, 2019
@ealymbaev
New ImageView class for loading and showing Erc20 Coin icons (#141)
74ffbda
ant013 added a commit that referenced this issue Feb 5, 2019
@ant013
Merge pull request #413 from horizontalsystems/icon_image_view_for_coins
d8f4d5e 
New ImageView class for loading and showing Erc20 Coin icons (#141)
ant013 added a commit that referenced this issue Feb 5, 2019
@ant013
ERC 20 Token support. Coin manager sync (#141)
3f98cbd 
- Add syncer for update erc20 coins from ipfs
ealymbaev added a commit that referenced this issue Feb 6, 2019
@ealymbaev
Merge pull request #414 from horizontalsystems/coin_manager_syncer
fb7a386 
ERC 20 Token support. Coin manager sync (#141)
mNizhurin added a commit that referenced this issue Feb 7, 2019
@mNizhurin
ERC20 tokens support (#141)
0ad12f8 
- implement available balance in adapters
- add fee error for ERC20
mNizhurin added a commit that referenced this issue Feb 8, 2019
@mNizhurin
Support ERC20 #141
079b4f0 
- transfer fee error to GUI
mNizhurin added a commit that referenced this issue Feb 11, 2019
@mNizhurin
Support ERC20 #141
79e785f 
- show fee error
mNizhurin added a commit that referenced this issue Feb 12, 2019
@mNizhurin
Implement ETH fee for ERC20 tokens #141
4aec902 
- show fee in ETH
- use proper rate for fee
- fix rounding in confirmation controller
@mNizhurin mNizhurin mentioned this issue Feb 12, 2019
Merged
mNizhurin added a commit that referenced this issue Feb 12, 2019
@mNizhurin
Download rates for ETH when ERC20 is single selected coin #141
a338217
Version 0.2 automation moved this from In Progress to Done Feb 12, 2019
@Dianaaiym Dianaaiym moved this from Done to Accepted in Version 0.2 Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ant013 ant013

Labels
feature New feature
Projects
No open projects
Version 0.2
  
Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Erc20 fee in eth horizontalsystems/unstoppable-wallet-ios
3 participants
@esengulov @ant013 @Dianaaiym