Skip to content

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
Checking mergeability… Don’t worry, you can still create the pull request.
Commits on Apr 11, 2014
@wubin28 wubin28 Initialized the Java code for my exercises. bf1e38b
@wubin28 wubin28 Added the interface IAlarm to make code compiled successfully. 81bac2b
@wubin28 wubin28 Added an assertion for test given_psi_pressure_value_is_less_than_17_…
…when_check_then_alarm_is_on().
ac06f15
@wubin28 wubin28 Changed the test to be when_check_alarm_then_get_characterization(). 04771c4
@wubin28 wubin28 Made test when_check_alarm_then_get_characterization() passed. 71a9006
@wubin28 wubin28 Added an assertion to test given_psi_pressure_value_is_less_than_17_w…
…hen_check_alarm_then_alarm_is_on().
8ead805
@wubin28 wubin28 Mocked Sensor in test given_psi_pressure_value_is_less_than_17_when_c…
…heck_alarm_then_alarm_is_on().
7466f18
@wubin28 wubin28 Made test given_psi_pressure_value_is_less_than_17_when_check_alarm_t…
…hen_alarm_is_on() passed.
d23d69a
@wubin28 wubin28 Added test given_psi_pressure_value_is_greater_than_21_when_check_ala…
…rm_then_alarm_is_on() and it passed directly.
922848a
@wubin28 wubin28 Added test given_psi_pressure_value_is_between_17_and_21_when_check_a…
…larm_then_alarm_is_off() and it passed directly.
9149708
@wubin28 wubin28 Added an assertion for test when_pop_next_pressure_psi_value_then_get…
…_characterization().
b1be68e
@wubin28 wubin28 Made test when_pop_next_pressure_psi_value_then_get_characterization(…
…) passed.
fd2ca7b
@wubin28 wubin28 Renamed the test of Sensor to be when_pop_next_pressure_psi_value_the…
…n_it_is_between_18_and_19().
ca788e1
Commits on Apr 14, 2014
@wubin28 wubin28 Initialized C# code for exerciese. 8f6d459
Commits on Apr 15, 2014
@wubin28 wubin28 Added an assertion for test WHEN_check_pressure_value_in_alarm_THEN_g…
…et_characterization_of_whether_alarm_is_on().
72d091c
@wubin28 wubin28 Got characterization from the test. But the result was random. Will m…
…ock the random part to make the assertion constant.
5a3864c
@wubin28 wubin28 Wrote expected code for injecting a Sensor object while instantiating…
… an Alarm object.
5527b9d
Commits on Apr 16, 2014
@wubin28 wubin28 Mocked the Sensor in the test. 01aa6f4
@wubin28 wubin28 Set up the mocked Sensor in the test. But got error message 'System.N…
…otSupportedException : Invalid setup on a non-virtual (overridable in VB) member: s => s.PopNextPressurePsiValue()'. Will extract interface for class Sensor.
412ae9f
@wubin28 wubin28 Extracted interface ISensor. 7e336ac
@wubin28 wubin28 Renamed the test to be GIVEN_pressure_psi_value_is_16_WHEN_check_pres…
…sure_value_in_alarm_THEN_alarm_is_on().
43b9b8e
@wubin28 wubin28 Added test GIVEN_pressure_psi_value_is_17_WHEN_check_pressure_value_i…
…n_alarm_THEN_alarm_is_off() and made it passed.
c078767
@wubin28 wubin28 Added test GIVEN_pressure_psi_value_is_21_WHEN_check_pressure_value_i…
…n_alarm_THEN_alarm_is_off() and it was passed.
443d040
@wubin28 wubin28 Added test GIVEN_pressure_psi_value_is_22_WHEN_check_pressure_value_i…
…n_alarm_THEN_alarm_is_on() and it was passed.
5b0e652
Commits on Apr 17, 2014
@wubin28 wubin28 Added test should_convert_ampersand() in test class UnicodeFileToHtml…
…TextConverterTest.
6087397
@wubin28 wubin28 Created class TestingUnicodeFileToHtmlTextConverter which is the subc…
…lass of UnicodeFileToHtmlTextConverter.
f7ac0dc
@wubin28 wubin28 Extracted method OpenTextReader() in class UnicodeFileToHtmlTextConve…
…rter which is going to be overridden by the subclass TestingUnicodeFileToHtmlTextConvert.
9a37943
@wubin28 wubin28 Changed the return type of method UnicodeFileToHtmlTextConverter.Open…
…TextReader() to be TextReader.
60b3739
@wubin28 wubin28 Overrode method OpenTextReader() in class TestingUnicodeFileToHtmlTex…
…tConverter.
25a13e5
@wubin28 wubin28 Extracted method OpenStringReader() in class TestingUnicodeFileToHtml…
…TextConverter.
e9efd04
@wubin28 wubin28 Introduced parameter strToBeConverted in method TestingUnicodeFileToH…
…tmlTextConverter.OpenStringReader() to make the business logic clear.
23e5d87
Commits on Apr 18, 2014
@wubin28 wubin28 Added test GIVEN_dispense_a_ticket_WHEN_check_ticket_turn_number_THEN…
…_get_characterization().
504e104
@wubin28 wubin28 Made test GIVEN_dispense_a_ticket_WHEN_check_ticket_turn_number_THEN_…
…get_characterization() passed.
a262f86
@wubin28 wubin28 Added test GIVEN_dispense_a_ticket_WHEN_dispense_a_new_ticket_THEN_tu…
…rn_number_of_the_new_ticket_is_greater() and made it passed.
7b24796
@wubin28 wubin28 Added test GIVEN_dispense_a_ticket_WHEN_dispense_a_new_ticket_at_anot…
…her_machine_THEN_turn_number_of_the_new_ticket_is_greater() and made it passed.
26d90b2
@wubin28 wubin28 Added an assertion for test GIVEN_dispense_ticket_number_10_WHEN_disp…
…ense_a_new_ticket_THEN_the_new_ticket_is_number_11().
2a591d9
@wubin28 wubin28 Used an instance of TestingTicketDispenser in test GIVEN_dispense_tic…
…ket_number_10_WHEN_dispense_a_new_ticket_THEN_the_new_ticket_is_number_11().
8bea33a
@wubin28 wubin28 Created class TestingTicketDispenser. 722d44d
@wubin28 wubin28 Tried to mock class TurnNumberSequence. But moq4 cannot mock a static…
… type.
ac8e105
@wubin28 wubin28 Changed class TurnNumberSequence and its method GetNextTurnNumber() t…
…o be non-static for mocking. Mocked class TurnNumberSequence in TestingTicketDispenser.GetTurnTicket().
772fcc4
@wubin28 wubin28 Added an assertion in test WHEN_check_Transmision_THEN_get_characteri…
…zation().
c619bd9
@wubin28 wubin28 Got characterization from test WHEN_check_Transmision_THEN_get_charac…
…terization().
2e75000
@wubin28 wubin28 Renamed the test to be WHEN_check_Transmision_THEN_diagnostic_request…
…_should_be_sent_and_message_should_be_got() and mocked class TelemetryClient in it.
d8dfa2d
@wubin28 wubin28 Created a constructor of class TelemetryDiagnosticControls to inject …
…an instance of TelemetryClient.
f4a0767
Commits on Apr 19, 2014
@wubin28 wubin28 Renamed test to be GIVEN_online_status_of_TelemetryClient_is_tue_WHEN…
…_check_Transmision_THEN_method_Disconnect_Send_and_Receive_should_be_invoked() and mocked TelemetryClient in it.
dd31f08
@wubin28 wubin28 Somehow t => t.Connect(*111#) never performed. b9a5ce6
@wubin28 wubin28 Added test GIVEN_on_happy_path_WHEN_check_transmission_THEN_get_chara…
…cterization() to mock Random in TestingTelemetryClient.
b7defe3
@wubin28 wubin28 Created class TestingTelemetryClient to use Subclass and Override for…
… mocking random behaviours in class TelemetryClient.
e51c4a6
@wubin28 wubin28 Injected 3 random numbers (connectionEventsRandomNumberFrom1To10, mes…
…sageRandomNumberFrom50To110, messageRandomNumberFrom40To126) through the constructor parameters of class TestingTelemetryClient.
8510a05
@wubin28 wubin28 Implemented the constructor of TestingTelemetryClient for injecting t…
…he three random numbers.
fe3267a
@wubin28 wubin28 Introduced parameter connectionEventsRandomNumberFrom1To10 for method…
… TelemetryClient.Connect().
9443ce0
@wubin28 wubin28 Introduced parameter messageRandomNumberFrom50To110 and messageRandom…
…NumberFrom40To126) for method TelemetryClient.Receive().
300ef10
@wubin28 wubin28 Overrode method Connect() and Receive() in class TestingTelemetryClient. e6e36fa
@wubin28 wubin28 Added test GIVEN_not_online_to_server_WHEN_check_transmission_THEN_ge…
…t_exception() and made it passed.
8e8cdd9
@lucaminudel lucaminudel Merge pull request #29 from wubin28/master
Wubin28: My C# solution for the 4 katas finished.
efb892c
Commits on May 21, 2014
@lucaminudel lucaminudel TirePressure/PHP added missing include 46af52f
@lucaminudel lucaminudel TirePressure / Java : removed unnecessary mock/stab files that caused…
… compilation errors
e3ae539
@lucaminudel lucaminudel TirePressure / Java : aligned pom with the version of the library in …
…/lib
9959151
@lucaminudel lucaminudel TirePressure / Java : aligned pom with the version of the library in …
…/lib
8c49fe7
Commits on Jun 11, 2014
@wubin28 wubin28 Added git ignore rules for IDEA. 707366d
@wubin28 wubin28 Created the test class TicketDispenserTest and added a trivial test. 73e265a
@wubin28 wubin28 Added TODO: Depending on a static method violates the Dependency Inve…
…rsion Principle and Open-Closed Principle.
8927ebc
@wubin28 wubin28 Added 3 acceptance test TODOs. 2542708
@wubin28 wubin28 Finished TODO: a new ticket should have the turn number subsequent to…
… the previous ticket.
30964c4
@wubin28 wubin28 Finished TODO: a new ticket should have the turn number subsequent to…
… the previous ticket from another dispenser.
6ce58d0
@wubin28 wubin28 Working on TODO: after ticket 10 come ticket 11. Wrote intention code…
… for the test of this TODO.
148ef5d
@wubin28 wubin28 Created class TestingTurnNumberSequence and made it to be the subclas…
…s of TurnNumberSequence.
aed41c8
@wubin28 wubin28 Created and implemented method TestingTurnNumberSequence.setCurrentTu…
…rnNumber().
fcca28e
@wubin28 wubin28 Made the field TurnNumberSequence.turnNumber accessable for its subcl…
…ass.
fd32a13
@wubin28 wubin28 Created and implemented constructor TicketDispenser(TurnNumberSequence). de0ffff
@wubin28 wubin28 Created and implemented constructor TicketDispenser(). 6c13ede
@wubin28 wubin28 Finished TODO: Depending on a static method violates the Dependency I…
…nversion Principle and Open-Closed Principle.
b32189e
@wubin28 wubin28 Made method TurnNumberSequence.getNextTurnNumber() return the calcula…
…ted turn number.
646bdcb
@wubin28 wubin28 Finished TODO: after ticket 10 come ticket 11. dd25c48
Commits on Sep 25, 2014
@rationalrevolt rationalrevolt Added my solutions 9b7b63b
Commits on Nov 09, 2014
@lucaminudel lucaminudel Merge pull request #31 from rationalrevolt/master
Added my solutions
8240bf3
Commits on Nov 16, 2014
@lucaminudel lucaminudel TirePressureMonitoringSystem/java In Sensor removed seed for the rand…
…om function.
82c60f0
@lucaminudel lucaminudel TirePressureMonitoring/Cpp Added Cpp porting from Emily racing kata repo 4abda94
@lucaminudel lucaminudel TireTirePressureMonitoring/Scala Added Cpp porting from Emily racing …
…kata repo
fb3ce56
@lucaminudel lucaminudel textConverter/Scala Added Scala porting from Emily racing kata repo 827c830
@lucaminudel lucaminudel textConverter/Scala Added Scala porting from Emily racing kata repo 0651499
@lucaminudel lucaminudel Added suggested Quick Start instructions for the dojo. 827d8c2
@lucaminudel lucaminudel Slides: updated with extra info for exercise 3 (TicketDispenser) and …
…new languages are included.
65ee3ed
@lucaminudel lucaminudel Updated comments and added instructions and agenda for the coding doj…
…o facilitator.
b653eea
@lucaminudel lucaminudel Instructions updated. 18de4b7
@lucaminudel lucaminudel Instructions updated. 7b72e41
@lucaminudel lucaminudel Instructions updated. 0b5299a
@lucaminudel lucaminudel Instructions updated. bdff56a
@lucaminudel lucaminudel Instructions updated. 40cfe74
Commits on Nov 22, 2014
@lucaminudel lucaminudel Update README.md 933e777
@lucaminudel lucaminudel Update README.md 6e5db1c
Commits on Jan 05, 2015
@lucaminudel lucaminudel Merge pull request #30 from wubin28/master
Used "Subclass and set superclass' field" to verify the next turn number should be increased by 1
d813329
Commits on Sep 12, 2015
@codecop codecop ignore IDEA files in Java exercise folder 4a1bfd4
@codecop codecop remove empty test in one Java exercises as the other exercises do not…
… have empty tests
86c82c4
@codecop codecop make all links into same repo relative 45e7f7f
@codecop codecop format Java exercises (only whitespace change), rename 3 fields to co…
…nform to Java conventions
d720aa2
@codecop codecop remove Eclipse generated and binary/build generated files from Java s…
…olution of viswans, should have been ignored
9e5054b
@codecop codecop remove lib jar from Java exercise as it is provided by Maven in solut…
…ion of benwu
d063d9d
@codecop codecop merge ignores in solution of benwu 703d651
@codecop codecop remove folder Java from solution of Roberto-Simoni for consistency b05ea81
@codecop codecop update version of JUnit and Java in Java exercises, format pom f2639a6
@codecop codecop link to comments for facilitator needs to be a raw=true link b14396e
@codecop codecop delete part of solution of benwu, code has not been changed, this is …
…no solution, just a copy
248eccb
Commits on Sep 13, 2015
@lucaminudel lucaminudel Merge pull request #32 from codecop/master
Minor cleanups for Java exercise and solutions
85a8b3a