ROIs

[omrd]

Is it possible to make all measurement (but not arrows) ROIs rotate through colors? For example, if I have 10 length measurements on a slice, it would be nice if the first one is blue, the second one is yellow, third is green, etc...

Right now Osirix does an OK job of it but would be nice if it can be implemented in Horos. It's the only thing preventing me from making the jump.

[air-h-128k-il]

I tried.

(Japanese Version: '長さ' means 'Length')

(English Version: removing 'Length:')

But I managed some variables for changing color temporally.
After quiting 2D Viewer and re-running it, all ROI colors become same.

OsiriX MD memorize it?

[omrd]

That would be close to perfect if we can remove the label (I believe it's not in English in the last screenshot) all together and remove the black background all together. Is that possible?

[omrd]

It's on by default on OsiriX MD. It might be saved in preferences. It doesn't remember what the last color is between cases or restarts. Just that it randomly changes colors on each new study.

[air-h-128k-il]

omrd wrote:That would be close to perfect if we can remove the label (I believe it's not in English in the last screenshot) all together and remove the black background all together. Is that possible?

possible
(japanese)

(english)

[omrd]

That's it!

[air-h-128k-il]

omrd wrote:It's on by default on OsiriX MD. It might be saved in preferences. It doesn't remember what the last color is between cases or restarts. Just that it randomly changes colors on each new study.

Feel free to talk about the best UI you believe now.
For, example.

• transparency (characters) ----- half-transparency? or non-transparency?
• the number of colors ----- 10? or 20? or more?
• color identity ----- random? or identical(always same color everytime you use the ROI you want to)?
• and so on

I will take them into consideration for the next time I modify my Horos(my friends call it 'HorliX').

[omrd]

I think what you have is good.
• Characters should always be opaque as should the lines.
• I think 10 colors is enough but that's up to you. Colors should be relatively bright. For example the blue and red that you have are a bit hard to read. Especially on reports.
• It would be good if colors rotate in the same order every time. First one is yellow, second is blue, etc...
• Labels can be done as the image I provided above (with or without backgrounds).

[air-h-128k-il]

Hi, omrd.

I tried again!

How about this one?

[air-h-128k-il]

I choiced 10 colors which are less bright than the previous ones.
The color-order is green(default), topaz yellow, carrot orange, madonna blue......,when you are drawing.
But if you finish drawing the line, the all colors change.
The latest line you draw is always green in the above setting. The next latest one is topaz yellow. Next, carrot orange, Next, madonna blue.....
The color-order setting is freely determined because I add a variable and a function for ROI color management into ROI class.

[air-h-128k-il]

I noticed the coding manners of the sources, which (maybe) rossetantonie and the osirix team wrote, in this modification. Their coding style is somewhat procedure-oriented. Easy to write, but hard to read.
Recent major coding style is, of course, object-oriented.
It is difficult to say which is better. But object-oriented coding style is suitable for open-source project.

[air-h-128k-il]

By the way, you would like to apply your idea - ROI-color-rotation-UI - for ONLY staright line?
It is applicable in other ROI, for example AREA, as follows:

It is well shown also that the latest roi that you draw is almost green(default color).
mmm....carrot orange is difficult to read.....

[omrd]

All ROIs that measure anything (length, area, etc...). This is looking good but please don't forget removing the "Length:" label.

[air-h-128k-il]

OK.
I have made the download page for this version of HorliX.

https://phazor.info/HorliX/?page_id=105

You can download and use it, if you like.
And I would like to hear your review.

[brizolara]

Hi guys, thanks for being part of the community!

@air-h-128k-il Do you mind making a pull request of your nice work so we can assess the changes and the whole community can benefit of them? By your side, keeping up-to-date with Horos repository will bring you the constant infrastructure improvements and fixes.

All the best,

Tiago

[air-h-128k-il]

Hi, brizolara.

I like the concept of Horos Project.

I can make the pull request but would like to hear the omrd's opinion before doing so.
Because he has claimed that the ROI-color-rotation-system is his original idea (not OsiriX team's).
I want to respect his thought even if his idea is a just idea.

[omrd]

Yes a pull request is a great idea.

[air-h-128k-il]

Hello,

@omrd I believe you are satisfied with my HorliX.

@brizolara I will make the pull request because I think it is better to unify HorliX/Horos UI like this case.
Before doing so, I will change my air-h-128k-il/HorliX repositry configuration as follows:

horlix branch - For me and 'hacker'-type developers. This branch includes advanced, experimental
and cutting-edge funcitions (auto-segmentation, computer-assisted-diagnosis, linking EHR systems,.....)

horos branch(or brand new horos repository) - This branch is to catch up with the latest your horosproject/horos branch and also includes my minor modifications for 'Horos.app'.

I will make the pull request from my horos branch after finishing the above re-configuratuon.

[fvpolpeta]

Hi @air-h-128k-il

Do you have in mind when you will be able to push this as pull request?

We are planning to release Horos 3.1.2 near soon and your contribution is very welcome.

Thanks

Fauze

[air-h-128k-il]

Hello, Horos guys.

The remaining problem is the credit.
I want you to credit our name somewhere in Horos project like:
' Horos ver 3.1.2 refines UI, for example, ROI-color-rotation-system proposed by omrd and implemented by air-h-128k-il ' (in twitter or blog or HomePage...)

OK?

[aglv]

Credit is indeed an issue. It would be appreciated if our contributions were somehow acknowledged in a way that's visible to the end users.

[DD-P]

If you did want to make the contributors more visible in the software itself, could I suggest that the about box no longer needs to thank "Mac OS X", "Cocoa and Xcode" etc? Perhaps a redo could reference the open-source building blocks, but then highlight the leaders of both the original and this project, together with its sub-projects and other assorted contributors (although I have no idea how many people that might represent).

[fvpolpeta]

Fair point guys. I will come up with something. I will be discussing this internally with my Purview peers (sponsors of the project and Horos marketing heads). I consider tweeter too ephemeral. Something in the release notes and/or in the public announcement notes sounds like something more persistent.

[fvpolpeta]

Hey there -

As suggested by DD-P we will be soon reviewing the about box, and planning to add some tabbed sections there where will be presenting:

=> Technology: list of core APIs and third-party projects that are the foundation of Horos
=> Sponsors
=> Release Notes: backlog of changes with acknowledgement to collaborator(s)/developer(s) that promoted them
=> Team (including reference to [external and active] collaborators)

Your feedback is welcome.

Thanks for using and help Horos.

Fauze

[air-h-128k-il]

looks nice!

[air-h-128k-il]

By the way, I have worked for PHAZOR, LLC, a healthcare consulting company in Japan, recent 5 years or so. The CEO of the company asked purVIEW about the credit issue via e-mail last week.
But purVIEW hasn't replied anything.
I would like to wait for the reply.

[fvpolpeta]

Hi - Sounds good. I will be replying back to his enquiry in name of Purview. Thank you so much.

[air-h-128k-il]

Hi,
We have received your e-mail.
Thanks.

[Tyra3ll]

After the ROI-color-rotation-UI has made it's way to the current Horus version... Please - how is it possible to deactivate it? Or how can I choose the colors it is using? Some colors are barely visible on a black background.

Thanks, Mark

[air-h-128k-il]

Hi, peczkoma

I selected 9 colors mainly from this web site: https://www.colordic.org/y/ https://www.colordic.org/p/ https://www.colordic.org/v/
You should propose desirable colors to Horos users and developers, especially Horos guys.

[fvpolpeta]

We will be adding a setting in version 3.2.1 that will enable you to deactivate that.

Planned to be released next week.

Fauze

[brizolara]

Hi @peczkoma , thanks for your contact.

You should be able to change a ROI's color by double-clicking on it.

Meanwhile, we'll assess the issue of persistency of the ROIs colors between Horos sessions.

Best,

Tiago

[air-h-128k-il]

excellent!

@brizolara
I haven't read your sophisticated source code yet. sorry!
The format of xxx.roi in horos Ver3.2.0 is identical to one in OsiriX MD?

[ClaraPC]

Hi! I would like to know how to make the text brighter.
The opacity is already at the maximum.
Any clues? Thank you!

[omrd]

When I look at the color box, there's a triangle at the top right edge. I believe that means that opacity is not at the maximum. I would double check that again.

[ClaraPC]

Thanks. I checked, and it is at the maximum. I also compared with the lines, which are bright, and still, I cannot see any difference in the settings.

[Pugio]

I am having the same issue with weirdly faint text ROIs, using:

Horos 3.3.6
macOS 10.15.5

I have confirmed that the opacity slider is definitely at 100%, but the text is still faint.

I can also confirm this was working on version 3.3.5, and this fading was introduced in 3.3.6.

[szintax]

Hi everyone!
I join the question of Pugio.
I use a Macbook Pro M1 Max (macos Monterey 12.6.1) and Horos v4.0.0 RC5 . The color of the text is pale and dark. All other ROIs are displayed correctly. On my old Macbook Pro Retina with Intel core i7 (macos Catalina 10.15.7) the text is displayed in "normal" colors as .
I would be very glad for hints/help!
Thank you in advance
Dagmar