Skip to content
Permalink
Browse files

Switch safe_shell_exec() from byte stdout/stderr to text stdout/stderr (

#917)

Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
  • Loading branch information...
alsrgv committed Mar 15, 2019
1 parent 981740d commit 57bd00d812a7177f486bc14e1035252f0094ad44
Showing with 1 addition and 5 deletions.
  1. +1 −5 horovod/spark/util/safe_shell_exec.py
@@ -53,11 +53,7 @@ def terminate_executor_shell_and_children(pid):


def forward_stream(src_fd, dst_stream):
if hasattr(dst_stream, 'buffer'):
# If dst stream is a text buffer, we need to get its binary buffer.
dst_stream = dst_stream.buffer

with os.fdopen(src_fd, 'rb') as src:
with os.fdopen(src_fd, 'r') as src:
while True:
line = src.readline()
if not line:

0 comments on commit 57bd00d

Please sign in to comment.
You can’t perform that action at this time.