Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not require cffi if pytorch build is disabled #1014

Merged
merged 1 commit into from Apr 19, 2019

Conversation

2 participants
@nluehr
Copy link
Contributor

commented Apr 15, 2019

When building Horovod with Pytorch plugin explicitly disabled, do not add cffi to the dependency list.

Do not require cffi if pytorch build is disabled
Signed-off-by: Nathan Luehr <nluehr@nvidia.com>

@nluehr nluehr force-pushed the nluehr:skip-cffi-if-pytorch-disabled branch from 7aaaa1f to e3648d7 Apr 15, 2019

@alsrgv

alsrgv approved these changes Apr 19, 2019

Copy link
Collaborator

left a comment

LGTM, thanks!

@alsrgv alsrgv merged commit 2770fca into horovod:master Apr 19, 2019

2 checks passed

DCO DCO
Details
buildkite/horovod/pr Build #138 passed (42 minutes, 9 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.