Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MXNet breaking change #1031

Merged
merged 4 commits into from Apr 29, 2019

Conversation

3 participants
@yuxihu
Copy link
Contributor

commented Apr 28, 2019

Recently there was a breaking change introduced in MXNet master. This PR replaces the broken API with C API such that it will work with MXNet releases before and after the breaking change.

yuxihu added some commits Apr 28, 2019

use MXNDArrayReshape64 API
Signed-off-by: Yuxi Hu <darrenyxhu@gmail.com>
fix compiler warning
Signed-off-by: Yuxi Hu <darrenyxhu@gmail.com>
unpin MXNet nightly
Signed-off-by: Yuxi Hu <darrenyxhu@gmail.com>
@yuxihu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 28, 2019

@apeforest @alsrgv Please help review. Thanks.

@alsrgv

alsrgv approved these changes Apr 28, 2019

Copy link
Collaborator

left a comment

LGTM with minor comment

Show resolved Hide resolved horovod/mxnet/tensor_util.cc Outdated
address comment
Signed-off-by: Yuxi Hu <darrenyxhu@gmail.com>

@yuxihu yuxihu force-pushed the yuxihu:fix_tshape branch from 21abf70 to 84c09c5 Apr 28, 2019

@apeforest
Copy link
Contributor

left a comment

LGTM

@yuxihu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 29, 2019

@alsrgv We are ready to go.

@alsrgv alsrgv merged commit 6bee340 into horovod:master Apr 29, 2019

2 checks passed

DCO DCO
Details
buildkite/horovod/pr Build #235 passed (42 minutes, 11 seconds)
Details
@alsrgv

This comment has been minimized.

Copy link
Collaborator

commented Apr 29, 2019

Thanks, merged.

@yuxihu yuxihu deleted the yuxihu:fix_tshape branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.