Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing import for torch.nn.functional #1048

Merged
merged 1 commit into from May 7, 2019

Conversation

2 participants
@terrytangyuan
Copy link
Contributor

commented May 3, 2019

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

@alsrgv

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

I think it'd be better to just add import import torch.nn.functional as F.

@alsrgv alsrgv self-requested a review May 3, 2019

@terrytangyuan terrytangyuan changed the title Add missing torch.nn.functional. before nll_loss call Add missing import for torch.nn.functional May 3, 2019

@alsrgv

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

@terrytangyuan, thanks! Can you fix the DCO?

Add missing import for torch.nn.functional
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

@terrytangyuan terrytangyuan force-pushed the terrytangyuan:patch-2 branch from fe4dbb4 to c695590 May 4, 2019

@terrytangyuan

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

@alsrgv Fixed. Do you know if there's a way to automatically do this on the Github UI for simple changes like these (had to do this locally with git)?

@alsrgv

This comment has been minimized.

Copy link
Collaborator

commented May 7, 2019

@terrytangyuan, no :-( I didn't look hard though. Thanks for the PR!

@alsrgv

alsrgv approved these changes May 7, 2019

Copy link
Collaborator

left a comment

LGTM

@alsrgv alsrgv merged commit 73d860f into horovod:master May 7, 2019

2 checks passed

DCO DCO
Details
buildkite/horovod/pr Build #258 passed (44 minutes, 55 seconds)
Details

@terrytangyuan terrytangyuan deleted the terrytangyuan:patch-2 branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.