Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for TensorFlow 2.0 #1193

Merged
merged 8 commits into from Jul 8, 2019

Conversation

2 participants
@alsrgv
Copy link
Member

commented Jul 4, 2019

  • Support for TensorFlow 2.0 in horovod.tensorflow
  • Replace RMSProp with Adam (RMSProp doesn't scale)
  • Minor example bugfixes

Fixes #1177

Initial support for TensorFlow 2.0
* Support for TensorFlow 2.0 in `horovod.tensorflow`
* Replace RMSProp with Adam (RMSProp doesn't scale)
* Minor example bugfixes

Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>

@alsrgv alsrgv requested review from tgaddair, abditag2 and sblotner Jul 4, 2019

@alsrgv alsrgv self-assigned this Jul 4, 2019

alsrgv added some commits Jul 4, 2019

Bugfixes, enable subgraph caching
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
Bugfixes & performance improvements
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
Revert RMSprop changes in Keras tests
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
Renamed examples tensorflow_20_* -> tensorflow2_*
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
Support for TensorFlow 2.0 tests
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
Bugfix Keras test exclusion logic
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>
@tgaddair
Copy link
Collaborator

left a comment

Sweet! Seems there's a lot of compatibility code that was introduced. I wonder if we can either clean that up somehow, or at least comment on which versions we're ensuring compatibility with for each of these special cases.

Show resolved Hide resolved examples/tensorflow2_mnist.py
Show resolved Hide resolved examples/tensorflow2_mnist.py Outdated
Show resolved Hide resolved examples/tensorflow2_mnist.py
Show resolved Hide resolved examples/tensorflow2_mnist.py Outdated
Show resolved Hide resolved horovod/tensorflow/__init__.py
Show resolved Hide resolved horovod/tensorflow/__init__.py Outdated
Show resolved Hide resolved horovod/tensorflow/__init__.py Outdated
Show resolved Hide resolved horovod/tensorflow/__init__.py Outdated
Show resolved Hide resolved horovod/tensorflow/__init__.py
Show resolved Hide resolved horovod/tensorflow/util.py
Address review comments
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>

@alsrgv alsrgv merged commit 15692da into master Jul 8, 2019

3 checks passed

DCO DCO
Details
License Compliance All checks passed.
Details
buildkite/horovod/pr Build #662 passed (57 minutes, 51 seconds)
Details

@alsrgv alsrgv deleted the tf20 branch Jul 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.