Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separately build gloo for each plugins #1209

Merged
merged 2 commits into from Jul 11, 2019

Conversation

3 participants
@zsh-thu
Copy link
Contributor

commented Jul 10, 2019

This pr is an amendment to the pr that Alex created for autodetecting matching gcc compiler. Since different plugins may be compiled using different compilers, the gloo needs to be compiled with the same compiler, which means gloo should be compiled each time a plugin is compiled.

separately build gloo for each plugins
Signed-off-by: Sihan Zeng <zsh@uber.com>

@tgaddair tgaddair requested a review from alsrgv Jul 10, 2019

@tgaddair
Copy link
Collaborator

left a comment

LGTM. Let's also get @alsrgv to take a look.

@alsrgv

alsrgv approved these changes Jul 11, 2019

Copy link
Member

left a comment

LGTM with formatting nits

Show resolved Hide resolved setup.py Outdated
Show resolved Hide resolved setup.py Outdated
Show resolved Hide resolved setup.py Outdated
Show resolved Hide resolved setup.py Outdated
fix format
Signed-off-by: Sihan Zeng <zsh@uber.com>

@alsrgv alsrgv merged commit 958695e into horovod:master Jul 11, 2019

2 checks passed

DCO DCO
Details
buildkite/horovod/pr Build #704 passed (53 minutes, 29 seconds)
Details

@zsh-thu zsh-thu deleted the zsh-thu:gxx_gloo_support branch Jul 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.