Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Gloo mode to attempt changing directory into the current working directory that the command was launched from, if it exists, to be consistent with MPI #1298

Merged
merged 2 commits into from Aug 13, 2019

Conversation

@tgaddair
Copy link
Collaborator

commented Aug 13, 2019

Behavior parity with mpirun.

tgaddair added some commits Aug 13, 2019

Changed Gloo mode to attempt changing directory into the current work…
…ing directory that the command was launched from, if it exists, to be consistent with MPI

Signed-off-by: Travis Addair <taddair@uber.com>
Suppress output from command
Signed-off-by: Travis Addair <taddair@uber.com>

@tgaddair tgaddair requested a review from alsrgv Aug 13, 2019

@tgaddair tgaddair referenced this pull request Aug 13, 2019

Merged

Added Gloo controller #1181

@alsrgv

alsrgv approved these changes Aug 13, 2019

Copy link
Member

left a comment

LGTM, thanks!

@tgaddair tgaddair merged commit e621787 into master Aug 13, 2019

3 checks passed

DCO DCO
Details
License Compliance All checks passed.
Details
buildkite/horovod Build #946 passed (1 hour, 29 minutes, 44 seconds)
Details

@tgaddair tgaddair deleted the gloo_pwd branch Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.