Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin stricter versions for PyTorch 1.2.0 upgrade #1323

Merged
merged 1 commit into from Aug 20, 2019

Conversation

@alsrgv
Copy link
Member

commented Aug 20, 2019

Previous upgrade #1320 did not take into account that PyTorch https://download.pytorch.org/whl/torch_stable.html is not usable for latest cuda10 releases, and that PyTorch silently ignores CUDA mismatch errors instead of loudly failing.

Pin stricter versions for PyTorch 1.2.0 upgrade
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>

@alsrgv alsrgv requested review from tgaddair and romerojosh Aug 20, 2019

@alsrgv alsrgv self-assigned this Aug 20, 2019

@alsrgv

This comment has been minimized.

Copy link
Member Author

commented Aug 20, 2019

See pytorch/pytorch#23656 for more details.

@alsrgv alsrgv merged commit 6cdcd0e into master Aug 20, 2019

3 checks passed

DCO DCO
Details
License Compliance All checks passed.
Details
buildkite/horovod Build #1019 passed (2 hours, 2 minutes, 54 seconds)
Details

@alsrgv alsrgv deleted the fix_pytorch_again branch Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.