Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kubeflow link error #1585

Merged
merged 1 commit into from Dec 16, 2019
Merged

Fix kubeflow link error #1585

merged 1 commit into from Dec 16, 2019

Conversation

@pingsutw
Copy link
Contributor

pingsutw commented Dec 14, 2019

Fix kubeflow link error

@tgaddair

This comment has been minimized.

Copy link
Collaborator

tgaddair commented Dec 15, 2019

Hey @pingsutw, thanks for the PR!

Just a couple things before we land. Could you sign the DCO. Also, please update index.rst to pass the Docs Summary Sync check.

@pingsutw pingsutw force-pushed the pingsutw:patch-1 branch 3 times, most recently from b611246 to 50f0d8c Dec 15, 2019
@pingsutw

This comment has been minimized.

Copy link
Contributor Author

pingsutw commented Dec 15, 2019

Thanks @tgaddair for the review.

  1. update index.rst
  2. update summary.rst
  3. sign the DCO.
@pingsutw

This comment has been minimized.

Copy link
Contributor Author

pingsutw commented Dec 15, 2019

The test fail seems unrelated

@tgaddair

This comment has been minimized.

Copy link
Collaborator

tgaddair commented Dec 15, 2019

Thanks for following up @pingsutw. Once #1587 lands we can rerun the tests. When they pass, I'll go ahead and land this.

@pingsutw

This comment has been minimized.

Copy link
Contributor Author

pingsutw commented Dec 16, 2019

Got it, thanks for the help

@tgaddair

This comment has been minimized.

Copy link
Collaborator

tgaddair commented Dec 16, 2019

@pingsutw, #1587 has landed. Please rebase your branch on master then push again. Unit tests should now succeed.

Signed-off-by: pingsutw <pingsutw@gmail.com>
@pingsutw pingsutw force-pushed the pingsutw:patch-1 branch from 50f0d8c to 7328435 Dec 16, 2019
@pingsutw

This comment has been minimized.

Copy link
Contributor Author

pingsutw commented Dec 16, 2019

rebase it. Thanks to @tgaddair

Copy link
Collaborator

tgaddair left a comment

LGTM! Thanks for the fix.

@tgaddair tgaddair merged commit 2063feb into horovod:master Dec 16, 2019
3 checks passed
3 checks passed
build
Details
DCO DCO
Details
buildkite/horovod/pr Build #1598 passed (51 minutes, 32 seconds)
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.