Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set set_shutdown flag in response_list when using cached communication path #1720

Merged
merged 1 commit into from Feb 11, 2020

Conversation

@romerojosh
Copy link
Collaborator

romerojosh commented Feb 11, 2020

When using the cached communication path, the shutdown flag in the generated response_list is left unset (defaults to false). I added the missing call to response_list.set_shutdown.

…munication path.

Signed-off-by: Josh Romero <joshr@nvidia.com>
@romerojosh romerojosh requested a review from tgaddair Feb 11, 2020
Copy link
Collaborator

tgaddair left a comment

Nice catch!

@tgaddair tgaddair merged commit c1c66fa into horovod:master Feb 11, 2020
5 checks passed
5 checks passed
build
Details
build
Details
DCO DCO
Details
buildkite/horovod/pr Build #2045 passed (30 minutes, 4 seconds)
Details
ppc64le-checks ppc64le Build/Tests Passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.