Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonize unit tests #1814

Merged
merged 1 commit into from Mar 25, 2020
Merged

Harmonize unit tests #1814

merged 1 commit into from Mar 25, 2020

Conversation

@EnricoMi
Copy link
Collaborator

EnricoMi commented Mar 23, 2020

Make skipped tests explicit and provide a reason.
Use common.temppath for temporary files and auto-delete them after use.
Fixe race condition in test_run.py where /tmp/hostfile is being written by both MPI threads and one reads the unfinished file of the other thread and fails. Now both use unique temporary filename.

Copy link
Collaborator

abditag2 left a comment

This is awesome! Let's fix the unittests.

@abditag2 abditag2 self-requested a review Mar 23, 2020
Make skipped tests explicit and provide reason. Use common.temppath
for temporary files and auto-delete them after use.

Signed-off-by: Enrico Minack <github@enrico.minack.dev>
@EnricoMi EnricoMi force-pushed the G-Research:branch-harmonize-tests branch from 4d584e2 to 2ca4baa Mar 24, 2020
@EnricoMi EnricoMi merged commit 4371007 into horovod:master Mar 25, 2020
5 checks passed
5 checks passed
build
Details
build
Details
DCO DCO
Details
buildkite/horovod/pr Build #2303 passed (1 hour, 12 minutes, 36 seconds)
Details
ppc64le-checks ppc64le Build/Tests Passed
Details
@EnricoMi EnricoMi deleted the G-Research:branch-harmonize-tests branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.