New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MXNet: support Gluon Trainer API #809

Merged
merged 6 commits into from Feb 7, 2019

Conversation

3 participants
@yuxihu
Copy link
Contributor

yuxihu commented Feb 5, 2019

This PR makes the following changes:

  1. support broadcast parameter which type is ParameterDict
  2. update imagenet example to provide an option to train with Gluon Trainer API
@yuxihu

This comment has been minimized.

Copy link
Contributor Author

yuxihu commented Feb 5, 2019

@apeforest please review

@alsrgv

alsrgv approved these changes Feb 5, 2019

Copy link
Collaborator

alsrgv left a comment

LGTM, will wait for @apeforest to review before merging.

Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated
Show resolved Hide resolved README.md Outdated

@yuxihu yuxihu force-pushed the yuxihu:gluon branch from 3fcc7dd to 357e649 Feb 6, 2019

yuxihu added some commits Feb 6, 2019

@apeforest
Copy link
Contributor

apeforest left a comment

LGTM

@yuxihu

This comment has been minimized.

Copy link
Contributor Author

yuxihu commented Feb 7, 2019

@alsrgv This PR is ready to go. Please help review and merge. Thanks.

@alsrgv alsrgv merged commit f7a24e6 into horovod:master Feb 7, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@alsrgv

This comment has been minimized.

Copy link
Collaborator

alsrgv commented Feb 7, 2019

Thanks!

@yuxihu yuxihu deleted the yuxihu:gluon branch Feb 8, 2019

apeforest added a commit to apeforest/horovod that referenced this pull request Feb 12, 2019

MXNet: support Gluon Trainer API (horovod#809)
Signed-off-by: Lin Yuan <apeforest@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment