Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MXNet example in README.md #872

Merged
merged 1 commit into from Mar 2, 2019
Merged

Conversation

eric-haibin-lin
Copy link
Collaborator

@eric-haibin-lin eric-haibin-lin commented Feb 28, 2019

No need to call split_and_load , which is meant for splitting data when the number of context is greater than 1. Calling as_in_context should be sufficient. Also I made the training loop simpler.

@alsrgv
Copy link
Member

alsrgv commented Feb 28, 2019

cc @yuxihu, @apeforest

@eric-haibin-lin, thanks for the PR, could you update it with DCO?

batch_axis=0)
label = gluon.utils.split_and_load(batch.label[0], ctx_list=[context],
batch_axis=0)
data = batch.data[0].as_in_context(context)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please apply the same change to the imagenet example?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do

update imagenet example

Signed-off-by: Haibin Lin <linhaibin.eric@gmail.com>
Copy link
Collaborator

@yuxihu yuxihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@alsrgv
Copy link
Member

alsrgv commented Feb 28, 2019

Thanks for the PR! Looks like pytorch/vision#768 broke our integration tests. I'll see if they make a fix today, otherwise, I'll fix our integration tests and ask you to rebase.

Copy link
Member

@apeforest apeforest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified running the script on GPU

@alsrgv alsrgv merged commit 9dbf8ff into horovod:master Mar 2, 2019
jeffdaily pushed a commit to ROCm/horovod that referenced this pull request Nov 27, 2019
update imagenet example

Signed-off-by: Haibin Lin <linhaibin.eric@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants