New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MXNet example in README.md #872
Conversation
cc @yuxihu, @apeforest @eric-haibin-lin, thanks for the PR, could you update it with DCO? |
batch_axis=0) | ||
label = gluon.utils.split_and_load(batch.label[0], ctx_list=[context], | ||
batch_axis=0) | ||
data = batch.data[0].as_in_context(context) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please apply the same change to the imagenet example?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will do
9629cdf
to
bfa051c
Compare
update imagenet example Signed-off-by: Haibin Lin <linhaibin.eric@gmail.com>
bfa051c
to
c6adbeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the PR! Looks like pytorch/vision#768 broke our integration tests. I'll see if they make a fix today, otherwise, I'll fix our integration tests and ask you to rebase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Verified running the script on GPU
update imagenet example Signed-off-by: Haibin Lin <linhaibin.eric@gmail.com>
No need to call
split_and_load
, which is meant for splitting data when the number of context is greater than 1. Callingas_in_context
should be sufficient. Also I made the training loop simpler.