Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch safe_shell_exec() from byte stdout/stderr to text stdout/stderr #917

Merged
merged 1 commit into from Mar 15, 2019

Conversation

2 participants
@alsrgv
Copy link
Collaborator

alsrgv commented Mar 15, 2019

Makes downstream life easier, e.g. for #869.

Switch safe_shell_exec() from byte stdout/stderr to text stdout/stderr
Signed-off-by: Alex Sergeev <alsrgv@users.noreply.github.com>

@alsrgv alsrgv requested review from tgaddair and abditag2 Mar 15, 2019

@alsrgv alsrgv referenced this pull request Mar 15, 2019

Merged

Added horovodrun. #869

@alsrgv alsrgv merged commit 57bd00d into master Mar 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@alsrgv alsrgv deleted the switch_to_text_stream branch Mar 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.