Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Cinnamon 3.2 #695

Open
bendovercz opened this issue Nov 8, 2016 · 38 comments
Open

Add support for Cinnamon 3.2 #695

bendovercz opened this issue Nov 8, 2016 · 38 comments

Comments

@bendovercz
Copy link

Recently released Cinnamon 3.2 uses .menu instead of .popup-menu and .popup-menu-boxpointer according to linuxmint/cinnamon#5917.

@joaojotta
Copy link

joaojotta commented Nov 8, 2016

Cant wait for this fix. It's the little things that drive me nut! ):

@Madh93
Copy link

Madh93 commented Nov 12, 2016

Thanks for finding the problem 😄

@joaojotta
Copy link

This is the bug we're talking about, right?
screenshot from 2016-11-12 22-14-35

@Madh93
Copy link

Madh93 commented Nov 12, 2016

@joaojotta yes, and menu and other applets too. You can replace all .pop-menu and .popup-menu-boxpointer to .menu in cinnamon css to solve this problem.

@joaojotta
Copy link

joaojotta commented Nov 13, 2016

Already did but it didn't fix it.
I mean: it all becomes transparent except for text and buttons.

@horst3180
Copy link
Owner

I'm working on a fix right now. The menu thing isn't the only change required for 3.2, though.

@joaojotta
Copy link

Many thanks!!

@jmauss
Copy link

jmauss commented Nov 15, 2016

Looking forward to this fix as well, thanks!

@joaojotta
Copy link

I actually lost my interest for this update because Cinnamon is broken for now.
Something to do with Read 7 or what so...
I had to go back to 3.0 and everything is fine there.

@joaojotta
Copy link

Good news: more time for the update!! (:

@jmauss
Copy link

jmauss commented Nov 15, 2016

@joaojotta Problem is that 3.2 fixed a qt theming regression caused by QT 5.7. Hopefully this update comes sooner than later...

@joaojotta
Copy link

Let's hope. Love Cinnamon, love Arc (also Numix but it got huge since GTK3.20).

@horst3180
Copy link
Owner

Cinnamon 3.2 support added. Sorry for the delay, I was busy with life :D

@joaojotta
Copy link

Life?
The thing with awesome graphics but awful gameplay?
I play it from time to time too. Still so low on credits...

Thanks for the update!!!

@NicoHood
Copy link

@horst3180 can you please tag a new release once the cinnamon support works mostly? Users report that they really need this update for ArchLinux.

BTW: You should also consider to use PGP and sign the commit and the tarballs. This ensures that the packages for the linux distributions can be verified against integrity and authenticity. This is extremely important for every OS, so you would do everyone a favor in signing the tarballs with gpg. Thanks for your time :)

@horst3180
Copy link
Owner

@NicoHood Okay, done. Is the signing okay? I just added the tarball signature in addition to the signed commit,tag.

@GLTR87
Copy link

GLTR87 commented Nov 19, 2016

The theme looks great to me with Cinnamon 3.2 and a vertical panel.
Thanks for the work!

@joaojotta
Copy link

Working great here too with the latest Cinnamon (3.2) and GTK (3.22).

@NicoHood
Copy link

NicoHood commented Nov 20, 2016

@horst3180 Thanks a lot for the signing! However you need to upload your public key to one of the keyservers, otherwise users are unable to fetch it for building:

gpg --recv-keys C57DFF0D28DAAE97
gpg: keyserver receive failed: No data

Edit: The key is available now, maybe it was a delay or you updated it. Thanks!

I also found one for the opensuse build server, but this seems to be a different one:
https://pgp.mit.edu/pks/lookup?op=vindex&search=0x5A7D1D38BEB6D886

In general is is extremely important to sign the whole git history in order to verify the whole tree. So it would be best if you sign every new commit and the tags as well. There is an option to automatically sign every commit. If you sign the github tarball it is also important to verify what github put in the download, so you only sign their downloads if you trust the content (its unlikely that via https the download got modified, but always be sure to compare it with your local data).

-> Please also sign the icon theme

@morph027
Copy link

@morph027
Copy link

morph027 commented Nov 21, 2016

Found another inconsistent color (or is this intended?) in the notification area:

cinnamon-arc

@jfarthing84
Copy link

@morph027 I just noticed this too. I highly doubt it is intended.

@horst3180
Copy link
Owner

@morph027 Yeah, that is not intended, although it looks kinda fancy :D. I will look into it.

@jfarthing84
Copy link

jfarthing84 commented Nov 22, 2016

Also, some applets have left/right padding, and some don't. Namely, the User and Removable Drives applet seem to have it, from what I can tell. For the record, I prefer without.
screenshot from 2016-11-22 16-48-23 screenshot from 2016-11-22 16-48-26screenshot from 2016-11-22 16-48-28 screenshot from 2016-11-22 16-48-31

@euphonia
Copy link

I'll also add that 3.2 uses .launcher instead of .panel-launcher. Without it, the panel seems to default to the to Mint's cinnamon theme hover effect (on Arch). Adding this was good enough for me:

.launcher {
  margin: 1px;
  padding: 1px;
  transition-duration: 200;
  border: 0px solid transparent;

  &:hover {
    background-gradient-direction: none;
    border: 0px solid $selected_bg_color;

    .panel-bottom & { border-bottom-width: 1px; }
    .panel-top & { border-top-width: 1px; }
    .panel-left & { border-left-width: 1px; }
    .panel-right & { border-right-width: 1px; }
  }
}

@euphonia
Copy link

Also, the left/right padding thing mentioned by @jfarthing84 seems to be due to the min-width for popovers/menus being set to 200px. Smaller menus, like the user applet and the launcher right-click menus, leave gaps to the left and right, and larger menus, like sound and networking, don't.

Reducing the min-width to 100px seems to do the trick. Not setting it at all may be another option, but I don't know what side-effects that might have.

@abkieling
Copy link

I use Arc-Darker and after upgrading to Cinnamon 3.2.1 on Fedora 25 all applets are using the default Cinnamon theme background color.

@horst3180
Copy link
Owner

@alexkieling Did you only update Cinnamon, but not the theme?

@horst3180
Copy link
Owner

@morph027 @jfarthing84 @euphonia Thanks for the help. The remaining 3.2 issues should be fixed now.

@abkieling
Copy link

@horst3180 I installed the theme via Fedora 24 repository (https://software.opensuse.org/download.html?project=home%3AHorst3180&package=arc-theme-solid). I've got the latest from that repo. There is no Fedora 25 repository available yet.

@horst3180
Copy link
Owner

@alexkieling Oops, I forgot to update my OBS repo to the latest release (it was late). I triggered an update now, should be available shortly.

@abkieling
Copy link

@horst3180 Updated the theme via Fedora repository and it looks good.

@jfarthing84
Copy link

@horst3180 Will you be tagging another release soon so that we can get the official Arch package updated?

@morph027
Copy link

Confirmed, my issue is gone!

@nick-s-b
Copy link

I'm not sure if this is a Cinnamon-only issue (I haven't tried it with other DEs) so I apologize for adding it to this thread... About the only thing that bothers me about Arc is that tooltips for the default Arc theme (not Arc-dark) are white text on the dark background and not vice-versa. For example, this is Chromium tooltip:

Arc

Given that all the controls for Arc are dark text on white background, why aren't tooltips following this convention? I find it hard to read white text on dark backgrounds so I notice this all the time and it gives me eye strain. Is this is a bug with my Cinnamon install? How do I fix it? Thank you!

@liltinkerer
Copy link

It's broken with the new Linux Mint 18.1 'Serena' update, but I think it's because the PPA isn't updated. Correct?

@liltinkerer
Copy link

@horst3180 When will the updates hit PPA?

@morph027
Copy link

ael-code pushed a commit to ael-code/arc-theme that referenced this issue Feb 9, 2017
ael-code pushed a commit to ael-code/arc-theme that referenced this issue Feb 9, 2017
ael-code pushed a commit to ael-code/arc-theme that referenced this issue Feb 9, 2017
ael-code pushed a commit to ael-code/arc-theme that referenced this issue Feb 9, 2017
Ckath pushed a commit to Ckath/arc-undead-recolor that referenced this issue Aug 9, 2017
Ckath pushed a commit to Ckath/arc-undead-recolor that referenced this issue Aug 9, 2017
Ckath pushed a commit to Ckath/arc-undead-recolor that referenced this issue Aug 9, 2017
Ckath pushed a commit to Ckath/arc-undead-recolor that referenced this issue Aug 9, 2017
mstaal pushed a commit to mstaal/arc-theme that referenced this issue Nov 14, 2020
mstaal pushed a commit to mstaal/arc-theme that referenced this issue Nov 14, 2020
mstaal pushed a commit to mstaal/arc-theme that referenced this issue Nov 14, 2020
mstaal pushed a commit to mstaal/arc-theme that referenced this issue Nov 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests