Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] ens://url.eth support at same level as aliases #61

Open
mortimr opened this issue May 15, 2019 · 0 comments

Comments

@mortimr
Copy link
Member

commented May 15, 2019

Description

Add support for ens domains on every spot where we use addresses.

  • Refactor the alias system: make it a centralized entity, ContractName@instancealias format is used for smart contract aliases, @addressalias for simple address alias, and ens://mydomain.eth for ens domains

  • Add ability to add ens alias that works exactly like a normal alias, only it triggers sagas to resolve the ethereum address before adding it. Also, you should not be able to specify an ens domain as alias.

  • Make aliases work on all dispatchers / getters: not an internal resolution, should be done in the helper to keep code inside ethvtx as simple as possible. {from: '@coinbase', to: 'ens://mydomain.eth', value: 10} should be valid transaction parameters.

  • Add helpers to resolves aliases / ens domains that have been added in the store

  • Add dispatcher to add ens domain to the store and resolve it.

  • Add Domain Registry address as a configuration parameter of ethvtx, add abi when providing address.

Purpose

Make it easier for developers to use their ens domains without having to manually resolve the domains. Also make the alias system more useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.