Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails 6 #5

Merged
merged 23 commits into from
Jul 26, 2020
Merged

Rails 6 #5

merged 23 commits into from
Jul 26, 2020

Conversation

hoshinotsuyoshi
Copy link
Owner

No description provided.

@hoshinotsuyoshi
bundle update
eb62786
@hoshinotsuyoshi
Adjust to factory_bot 5 style
d818351 
$ rubocop --require rubocop-rspec --only FactoryBot/AttributeDefinedStatically --auto-correct
@hoshinotsuyoshi
$ git grep -l Feedjira::Feed.parse | xargs gsed -i 's/Feedjira::Feed.…
6a8b2ea 
…parse/Feedjira.parse/g'

https://github.com/feedjira/feedjira/blob/master/CHANGELOG.md#300
@hoshinotsuyoshi
bundle update: Update mysql2
4e43087
@hoshinotsuyoshi
bundle update: sassc-rails
23620ff
@hoshinotsuyoshi
Remove jquery-rails
afb2f36
@hoshinotsuyoshi
bundle update; Remove konacha / Update to Rails 5.0
1686fa7
@hoshinotsuyoshi
Remove needless lines
e495e15
@hoshinotsuyoshi
Remove needless lines in Dockerfile
cc8fe03
@hoshinotsuyoshi
rails app:update on Rails 5.0
51b9b4b
@hoshinotsuyoshi
Add app/assets/config/manifest.js
519146d
@hoshinotsuyoshi
Add gem 'rails-controller-testing'
6989800
@hoshinotsuyoshi
Monkeypatch is no longer needed
04251b0
@hoshinotsuyoshi
Change to new style
db3b264
@hoshinotsuyoshi
Suppress a warning
d479ba1
@hoshinotsuyoshi
Relax active_support dependency
cdc6521
@hoshinotsuyoshi
Rails 6
45f5f48
@hoshinotsuyoshi
$ git grep -l be_success | xargs gsed -i 's/be_success/be_successful/g'
c52586b
@hoshinotsuyoshi
DEPRECATION WARNING: Uniqueness validator will...
9a4bd24 
DEPRECATION WARNING: Uniqueness validator will no longer enforce case sensitive comparison in Rails 6.1. To continue case sensitive comparison on the :guid attribute in Item model, pass `case_sensitive: true` option explicitly to the uniqueness validator. (called from block (4 levels) in <top (required)> at /app/spec/lib/fastladder/crawler_spec.rb:53)
@hoshinotsuyoshi
DEPRECATION WARNING: Rails 6.1 will...
ec3af47 
DEPRECATION WARNING: Rails 6.1 will return Content-Type header without modification. If you want just the MIME type, please use `#media_type` instead. (called from block (3 levels) in <top (required)> at /app/spec/controllers/user_controller_spec.rb:29)
@hoshinotsuyoshi
$ git grep -l update_attributes | xargs gsed -i 's/update_attributes/…
24236e5 
…update/g'

DEPRECATION WARNING: update_attributes is deprecated and will be removed from Rails 6.1 (please, use update instead) (called from block in touch_all at /app/app/controllers/api_controller.rb:46)
@hoshinotsuyoshi
Avoid "Directly inheriting from ActiveRecord::Migration is not suppor…
1c00825 
…ted"
@hoshinotsuyoshi
Add .github/workflows/ci.yml
bb84313
@hoshinotsuyoshi hoshinotsuyoshi self-assigned this Jul 26, 2020
@hoshinotsuyoshi hoshinotsuyoshi changed the title [WIP] Rails 6 Rails 6 Jul 26, 2020
@hoshinotsuyoshi hoshinotsuyoshi merged commit bb84313 into master Jul 26, 2020
@hoshinotsuyoshi hoshinotsuyoshi deleted the bundle_update_rails_60_1 branch July 26, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hoshinotsuyoshi hoshinotsuyoshi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hoshinotsuyoshi