Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested query parameters always fail validation #130

Closed
HughbertD opened this issue Sep 9, 2022 · 0 comments · Fixed by #129
Closed

Nested query parameters always fail validation #130

HughbertD opened this issue Sep 9, 2022 · 0 comments · Fixed by #129

Comments

@HughbertD
Copy link
Contributor

HughbertD commented Sep 9, 2022 •
edited

Query string params such as ?filter[groupId] always fail validation because retrieving them via $this->request->query->has and $this->request->query->get doesn't work.

Instead I think the parameter names need to become dot notated, e.g.

filter[groupId] => filter.groupId

So that they can be retrieved via the Arr::get and Arr:has methods

This issue should be fixed by: #129
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle validation of nested query parameters e.g. ?filter[groupId]= HughbertD/spectator
1 participant
@HughbertD