Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ferry routes [Closes #251] #254

Merged
merged 3 commits into from
Jan 14, 2015
Merged

Show ferry routes [Closes #251] #254

merged 3 commits into from
Jan 14, 2015

Conversation

mapmeld
Copy link
Contributor

@mapmeld mapmeld commented Jan 11, 2015

Style based on how ferry routes are implemented in standard Mapnik: https://github.com/openstreetmap/mapnik-stylesheets/blob/master/inc/layer-ferry-routes.xml.inc

Screenshot from my environment (I don't have DEM data so it's a little off)

screen shot 2015-01-11 at 3 41 24 pm

@yohanboniface
Copy link
Collaborator

Thanks a lot @mapmeld for this! :)

I'm not sure though myself that ferry routes are in the scope of the "Humanitarian and development" focused rendering, but I'm not even sure it's not ;)
@skorasaurus @jaakkoh @severinmenard thoughts?

@mapmeld
Copy link
Contributor Author

mapmeld commented Jan 11, 2015

I noticed they were missing because I was recently mapping / hiking near Lascahobas, Haiti. We took a small ferry across the river to a very isolated village (zoom out from this area on OSM: http://www.openstreetmap.org/#map=16/18.8502/-71.9415 ). There are likely other, longer routes which are not yet on OSM, but people were relying on the ferry to travel to Lascahobas and do business there.

Also there are a few countries in the world made entirely of small islands; ferries are important to show there.

@yohanboniface
Copy link
Collaborator

Those sounds like good arguments :)

/* FERRIES
/* ================================================================== */

#ferry {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If route=ferry is a subset of #ferry, so we should add the filter on the main selector (#ferry[route='ferry']) otherwise we can have non ferry routes displayed with default style. Other option, that may the best, is to filter out in the SQL itself so we only have the routes we are interested in.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yohanboniface now that you mention it, I do have it filtered out in the SQL! I can simplify this quite a bit, then

@jaakkoh
Copy link

jaakkoh commented Jan 11, 2015

I agree that ferries / other alike are an important mode of transportation in many low-income countries and with that IMO certainly within the scope of economic development agenda. As/when they are an integral part of the transport system they fall into the need to sufficient base mapping that feed into disaster preparedness too. So, great if these could be integrated.
Thanks again and in advance!

@skorasaurus
Copy link
Collaborator

@mapmeld Good work :) I agree that they deserve to be included.

yohanboniface added a commit that referenced this pull request Jan 14, 2015
Show ferry routes [Closes #251]
@yohanboniface yohanboniface merged commit 320acc8 into hotosm:master Jan 14, 2015
@yohanboniface
Copy link
Collaborator

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants