New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show ferry routes [Closes #251] #254

Merged
merged 3 commits into from Jan 14, 2015

Conversation

Projects
None yet
4 participants
@mapmeld
Contributor

mapmeld commented Jan 11, 2015

Style based on how ferry routes are implemented in standard Mapnik: https://github.com/openstreetmap/mapnik-stylesheets/blob/master/inc/layer-ferry-routes.xml.inc

Screenshot from my environment (I don't have DEM data so it's a little off)

screen shot 2015-01-11 at 3 41 24 pm

@yohanboniface

This comment has been minimized.

Show comment
Hide comment
@yohanboniface

yohanboniface Jan 11, 2015

Member

Thanks a lot @mapmeld for this! :)

I'm not sure though myself that ferry routes are in the scope of the "Humanitarian and development" focused rendering, but I'm not even sure it's not ;)
@skorasaurus @jaakkoh @severinmenard thoughts?

Member

yohanboniface commented Jan 11, 2015

Thanks a lot @mapmeld for this! :)

I'm not sure though myself that ferry routes are in the scope of the "Humanitarian and development" focused rendering, but I'm not even sure it's not ;)
@skorasaurus @jaakkoh @severinmenard thoughts?

@mapmeld

This comment has been minimized.

Show comment
Hide comment
@mapmeld

mapmeld Jan 11, 2015

Contributor

I noticed they were missing because I was recently mapping / hiking near Lascahobas, Haiti. We took a small ferry across the river to a very isolated village (zoom out from this area on OSM: http://www.openstreetmap.org/#map=16/18.8502/-71.9415 ). There are likely other, longer routes which are not yet on OSM, but people were relying on the ferry to travel to Lascahobas and do business there.

Also there are a few countries in the world made entirely of small islands; ferries are important to show there.

Contributor

mapmeld commented Jan 11, 2015

I noticed they were missing because I was recently mapping / hiking near Lascahobas, Haiti. We took a small ferry across the river to a very isolated village (zoom out from this area on OSM: http://www.openstreetmap.org/#map=16/18.8502/-71.9415 ). There are likely other, longer routes which are not yet on OSM, but people were relying on the ferry to travel to Lascahobas and do business there.

Also there are a few countries in the world made entirely of small islands; ferries are important to show there.

@yohanboniface

This comment has been minimized.

Show comment
Hide comment
@yohanboniface

yohanboniface Jan 11, 2015

Member

Those sounds like good arguments :)

Member

yohanboniface commented Jan 11, 2015

Those sounds like good arguments :)

@yohanboniface

View changes

Show outdated Hide outdated roads.mss
/* FERRIES
/* ================================================================== */
#ferry {

This comment has been minimized.

@yohanboniface

yohanboniface Jan 11, 2015

Member

If route=ferry is a subset of #ferry, so we should add the filter on the main selector (#ferry[route='ferry']) otherwise we can have non ferry routes displayed with default style. Other option, that may the best, is to filter out in the SQL itself so we only have the routes we are interested in.

@yohanboniface

yohanboniface Jan 11, 2015

Member

If route=ferry is a subset of #ferry, so we should add the filter on the main selector (#ferry[route='ferry']) otherwise we can have non ferry routes displayed with default style. Other option, that may the best, is to filter out in the SQL itself so we only have the routes we are interested in.

This comment has been minimized.

@mapmeld

mapmeld Jan 12, 2015

Contributor

@yohanboniface now that you mention it, I do have it filtered out in the SQL! I can simplify this quite a bit, then

@mapmeld

mapmeld Jan 12, 2015

Contributor

@yohanboniface now that you mention it, I do have it filtered out in the SQL! I can simplify this quite a bit, then

@yohanboniface

View changes

Show outdated Hide outdated roads.mss
#ferry {
[route='ferry'] {
[zoom>=9] {
line-color: #55d;

This comment has been minimized.

@yohanboniface

yohanboniface Jan 11, 2015

Member

Can you move the color definition to the palette.mss file?

@yohanboniface

yohanboniface Jan 11, 2015

Member

Can you move the color definition to the palette.mss file?

@yohanboniface

View changes

Show outdated Hide outdated roads.mss
/* ================================================================== */
#ferry {
[route='ferry'] {

This comment has been minimized.

@yohanboniface

yohanboniface Jan 11, 2015

Member

Same remark here: no zoom in the selector means all zoom, so better to add zoom filter in the selector itself.

@yohanboniface

yohanboniface Jan 11, 2015

Member

Same remark here: no zoom in the selector means all zoom, so better to add zoom filter in the selector itself.

@yohanboniface

View changes

Show outdated Hide outdated roads.mss
line-dasharray: 4, 4;
}
[zoom>=13] {
line-color: #55d;

This comment has been minimized.

@yohanboniface

yohanboniface Jan 11, 2015

Member

Better trying not to duplicate declarations.

@yohanboniface

yohanboniface Jan 11, 2015

Member

Better trying not to duplicate declarations.

@jaakkoh

This comment has been minimized.

Show comment
Hide comment
@jaakkoh

jaakkoh Jan 11, 2015

I agree that ferries / other alike are an important mode of transportation in many low-income countries and with that IMO certainly within the scope of economic development agenda. As/when they are an integral part of the transport system they fall into the need to sufficient base mapping that feed into disaster preparedness too. So, great if these could be integrated.
Thanks again and in advance!

jaakkoh commented Jan 11, 2015

I agree that ferries / other alike are an important mode of transportation in many low-income countries and with that IMO certainly within the scope of economic development agenda. As/when they are an integral part of the transport system they fall into the need to sufficient base mapping that feed into disaster preparedness too. So, great if these could be integrated.
Thanks again and in advance!

@skorasaurus

This comment has been minimized.

Show comment
Hide comment
@skorasaurus

skorasaurus Jan 12, 2015

Collaborator

@mapmeld Good work :) I agree that they deserve to be included.

Collaborator

skorasaurus commented Jan 12, 2015

@mapmeld Good work :) I agree that they deserve to be included.

yohanboniface added a commit that referenced this pull request Jan 14, 2015

Merge pull request #254 from mapmeld/ferry
Show ferry routes [Closes #251]

@yohanboniface yohanboniface merged commit 320acc8 into hotosm:master Jan 14, 2015

@yohanboniface

This comment has been minimized.

Show comment
Hide comment
@yohanboniface

yohanboniface Jan 14, 2015

Member

Thanks :)

Member

yohanboniface commented Jan 14, 2015

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment