Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.3.0 Release #1568

Merged
merged 126 commits into from May 30, 2019

Conversation

Projects
None yet
@xamanu
Copy link
Member

commented May 13, 2019

Features:

  • #916, #1361, #1423, #1515 - Add inbox filtering, sorting, delete multiple
  • #1390 - Add delete message feature in individual message page
  • #893, #1421, #1487 - Restrict editor programs for mapping and validation stages
  • #1364 - Split tasks with arbitrary geometry
  • #1365, #1497 - Encourage user to provide email.
  • #602, #1481 - Make organisation and mapping type in project metadata panel required
  • #987, #1559 - Introduce option to require validators to be intermediate or advanced mappers
  • #796, #1483 - Message users on level upgrade
  • #1153, #1368, #1514 - Factor smaller project page refresh
  • #1188, #1410 - Add loading message in project page
  • #1524, #1525 - Increase time interval of has-new-messages requests to 1 min
  • #1344, #1348 - Provide more numbers about projects and users in internal api
  • #1508 - Define cascade relation for project chat
  • #1398, #1448, #1551 - Upgrades for backend and frontend dependencies
  • #1452 - Include postgres port as configuration parameter
  • #1327, #1332 - Replace Elastic Beanstalk with Cloudformation setup
  • #1453, #1513 - Add database dump for local testing
  • #1470, #1502 - Add script to cleanup projects with invalid geometries and low mapping rates
  • #1480, #1498 - Improve Docker setup and create makefile for automated setup and testing environment
  • #1494 - Extend gitignore
  • #1436, #1557, #1559 - Cleanup deprecated Dockerfiles, unsused shippable library, and removed Elastic Beanstalk configuration

Bugfixes:

  • #924, #1538 - Keep task selection when changes applied
  • #1529, #1564 - Fix broken overpass view by providing AOI
  • #1522, #1528 - Bring back the activity overview
  • #1552, #1556 - Repair invalidation of tasks marked with "bad imagery"
  • #1400, #1389 - Block access to pages for non-existing messages
  • #1505, #1507 - Reset bad imagery count on task reset
  • #1517 - Fix bugs on TaskInvalidationHistory.record_invalidation and projectMapService
  • #1547, #1548 - Fix several issues with database migrations
  • #1519, #1539 - Multiple fixes to python tests
  • #1451 - Include a few missing profile translate strings

Documentation

  • #1509 - Move documentation from the wiki into the code base docs directory
  • #1540 - Add Entity Relationship Diagram of the TM database
  • #1542 - Update and extend documentation on contribution guidelines
  • #1345 - Add install scripts for Debian 9, 10 and Ubuntu 18.04

Contributors

Many thanks to:

nrotstan and others added some commits Jan 20, 2019

Split tasks with arbitrary geometry
* Support splitting tasks with arbitrary geometry that don't correspond
to an OSM tile identified by x, y, zoom

* Remove front-end check ensuring task possesses valid x/y/zoom values
before offering Split Task button

* Upgrade Shapely to 1.6.4 to gain access to split() operation
Add inbox filtering, sorting, delete multiple
* Categorize messages into types (mentions, validation or invalidation
notifications, etc)

* Associate project and task with messages that are regarding a project
or task

* Allow users to filter their inbox messages by message category,
project, task, and from user

* Allow users to select and delete multiple messages at once from inbox
(with confirmation via modal dialog)
Merge pull request #1452 from JorgeMartinezG/postgres_port
Include postgres port as configuration parameter
Merge pull request #1448 from hotosm/update-angular
Update angular to 1.7.8 & some other dependencies
Merge pull request #1422 from nrotstan/issue-1364-split-arbitrary-geo…
…metry

Split tasks with arbitrary geometry. Closes #1364
User stats & other related endpoint changes (#1348)
* #1147 Authorised end points
* #1147 Count for projects mapped
* #1147 Date to str
* #1147 Additional field on stats endpoint
* #1147 Match time calculation for id & username fetch
Merge pull request #1410 from uwaiszaki/uwais_1188a
Add loading message in project page
Project stats endpoint related (#1344, #1147)
* Mappers count
* Tasks related
* Total Comments
* Area, author
* Due date, features to map
* Time related
Improve cloning process (#1458)
* Hide name on project clone
* Clone project metadata
* Update clone instructions to reality
* Handle changeset comments in clone
* Revert clone instructions
Merge pull request #1484 from hotosm/fix/user-no-project
Fix login for users without project activity
Merge pull request #1465 from hotosm/update-lint-requirements
Update flake8 and pycodestyle to fix problem when linting on atom-editor
Merge pull request #1483 from hotosm/notify-level-upgrade
Message users on level upgrade
Merge pull request #1486 from hotosm/fix/comments
Fix posting message when commenting

xamanu added some commits May 23, 2019

Merge pull request #1593 from hotosm/refresh-account-data-on-fetch
Update account data if logged-in user fetched
Merge pull request #1594 from hotosm/history_validation
Keep task history when task is validated
@xamanu

This comment has been minimized.

Copy link
Member Author

commented May 23, 2019

Thanks for the two fixes, @nrotstan and @JorgeMartinezG! Checked and deployed them on the testing instance.

@russdeffner

This comment has been minimized.

Copy link

commented May 23, 2019

Regarding messages: It seems the ones that originate from the Q/C panel are not associated with a project, although they should be...
messaging

@russdeffner

This comment has been minimized.

Copy link

commented May 23, 2019

Regarding all users 4&5: It seems Un-mark only sets it back to the last state, not 'clear marks'.
To reproduce: I mark a task as Bad Imagery, then 'invalidate', if I now click un-mark, it returns to Bad imagery, not 'ready for mapping'/clear. And continuing to click un-mark will just go back and forth between bad imagery and invalidated states; i.e. no way to 'reset' an individual task to 'clear'/ready to map state.

@russdeffner

This comment has been minimized.

Copy link

commented May 23, 2019

Regarding all users 2: when I, as admin/project manager go to another user's profile (i.e. to make them validator, etc) I get/see the warning about their email. Not sure if that's good or not, but wasn't expecting that.

@russdeffner

This comment has been minimized.

Copy link

commented May 23, 2019

Maybe found an unintentional change as nothing is mentioned about the individual Project Managers' Project Dashboard - but mine should have 500-600 between drafts, active and archive but is showing 0 in all three categories.

@russdeffner

This comment has been minimized.

Copy link

commented May 23, 2019

Regarding PM 3: This still isn't what I thought we had discussed. It works, but still doesn't allow for a PM to allow Advanced and/or Intermediate mappers to validate without the Validation role. I want to be able to say 'no validation role but only intermediate/advanced can validate' as it is, it only really allows the addition of eliminating Beginners with the Validator role, which really shouldn't happen in the first place and will be taken care of with better on-boarding process.

@ramyaragupathy

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

@russdeffner - Per this matrix here this code allows no validation role but only intermediate/advanced can validate'. Can you please help with setting this matrix better for various roles + mapping level?

@russdeffner

This comment has been minimized.

Copy link

commented May 27, 2019

@ramyaragupathy I went through the scenarios again and not sure why I had so much trouble before, but the matrix is fine and I think is working in the various scenarios. One thing that did confuse me is there is no displayed metadata for 'intermediate & advanced' so if you are a beginner with/without the role you will get message 'you don't have the role', even if the metadata says it's not required and/or you do have the role. But that can be solved with a simple re-wording of the message 'you don't meet requirements' or similar. Getting the additional metadata displayed on the project description should come eventually, but maybe looks/fits differently with redesign.

@ramyaragupathy

This comment has been minimized.

Copy link
Contributor

commented May 27, 2019

@russdeffner - roles & levels would undergo a change based on our team & orgs implementation. I suggest let's handle this along with the redesign.

Can you also share a screenshot from Network tab of your browser's console when you access your dashboard page? I'd like to see the Response for my-projects (api/v1/admin) endpoint for your authorization. This will help us narrow down the error quickly. Sharing my dashboard response screenshot for reference:

image

@xamanu

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Thanks @russdeffner for the extensive testing. I would like to give feedback to each of the points:

  • Unmarking tasks: @JorgeMartinezG has provided a PR (available on tasks-stage) that unmarks back to nothing when the state goes back to bad imagery or mapped: #1623
  • Not all messages are associated to a project. This should only be the case for past messages. And is probably not a big problem. We might want to fix this on the way. But I suggest not to see this as a blocker for the release.
  • Allow validation only to intermediate and advanced mappers: Seems to work as expected.
  • Project dashboard: We were not able to reproduce it locally or on staging with our users. Thanks @ramyaragupathy for digging into this. Hopefully with the screenshots we get more insight to fix this.
Merge pull request #1623 from hotosm/fix/unmark-2-ready
Reset status to ready when map has been previously validated
@russdeffner

This comment has been minimized.

Copy link

commented May 28, 2019

dashboard

Let me know if you need more/something else

@ramyaragupathy

This comment has been minimized.

Copy link
Contributor

commented May 29, 2019

Per chat w/ @russdeffner and @mataharimhairi - Russ's dashboard fetch fails with a timeout error. Mhairi's page loads well. May be it's just the amount of data (466 projects) - but the same works fine on production. Possibly the staging setup (configured to handle less traffic than production?) is causing this. I'd say let's go ahead and this should work fine on a production setup

@xamanu

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

Thank you all for contributing, testing and bugfixing. This is ready to be released. I'm coordinating with @arunasank for the deployments.

@xamanu

This comment has been minimized.

Copy link
Member Author

commented May 29, 2019

The deployments will include a downtime of the HOT TM (tasks.hotosm.org) for 2 hours. We are proposing to schedule it for tomorrow, 30 of May at 7:30am UTC.

arunasank and others added some commits May 29, 2019

Add the default changeset comment env variable to CloudFormation (#1638)
* add default changeset comment settings to cloudformation
Merge pull request #1649 from hotosm/comment-box
Add tm_default_changeset_comment to cfn-config JSON

@xamanu xamanu merged commit dac2b42 into master May 30, 2019

3 checks passed

ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: staging Your tests passed on CircleCI!
Details
ci/dockercloud (/devops/docker/tasking-manager/Dockerfile) Your image was successfully built in Docker Hub
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.