Join GitHub today
Add support for extra_properties in per task instructions #659
@hunt3ri I updated my code so that it doesn't include any the migration scripts anymore.
@3vivekb Hi vivek, I am not sure how to test this really. Any help would be appreciated on this PR. It will not really be able to be dealt with for at least a month or so as pierre is out of town and will not be able to look at it again before he returns.
Think you can help with it in some way? Test or provide a file and steps for testing? It is a feature I am totally not familiar with so I am not sure how to even test it.
I am happy to test it well if we can resolve the conflicts, but I do not have the skills to resolve the conflicts.
This bumped up in priority due to the MS Building footprints. Several folks would like to do the building imports based on arbitrary geometries (census tracts) which is what this enables.
Hi Pierre, thanks for working on this! I was able to successfully create new projects and call things like
One logistical issue may be blocking this (otherwise it is good to go). From my production database clone generated a while ago, it seems the
task_creation_mode column was not populated...probably because that extra snippet in the migration script was not there previously. This won't be a problem for new databases, but it may be the case that we need to generate another alembic version running this to be sure those who did use the migration script have that flag set properly.
Let me tag up with the sysadmin on slack to verify this is the case on the live database and not just my clone.
Hi Pierre, I added a database revision to handle the case where a database has been migrated prior to your changes. In addition, I also added to the migration script the case where zoom values were not none so that projects would not have a blank value.
I ran the revision file and it worked for a local clone (the ratio was about 9 to 1 for non-arbitrary versus arbitrary). If you are okay with these changes, then we should be set to merge. Thanks for your help getting this implemented!