Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Oct 8, 2014
  1. @carols10cents

    Update tests to use capybara methods instead of regex

    carols10cents authored
    This way, we're getting text as the user would see it.
    See: jnicklas/capybara#1341
Commits on Aug 6, 2014
  1. @wilkie
  2. @wilkie

    Adds testing for the admin page and admin role.

    wilkie authored
    Initial user gets admin role.
    Admin users can set admin properties.
    
    The only admin property is user account creation toggle.
Commits on Aug 5, 2014
  1. @wilkie

    Merge pull request #761 from ninjapanzer/capybara_update_717

    wilkie authored
    Capybara update 717
Commits on Oct 27, 2013
  1. @hindenbug

    refactor Users#reset_password_create action to reduce complexity

    hindenbug authored
    Extract password reset logic in PasswordService class.
Commits on Jun 2, 2013
  1. @ninjapanzer
  2. @ninjapanzer

    For some reason this failed the same tests in travis but not locally.

    ninjapanzer authored
    I also noticed that capy 2.1.0 is not compatible with 1.9.2 so rolling back to 2.0.3
  3. @ninjapanzer

    Updated to look for first match to remove abiguous errors upgrading t…

    ninjapanzer authored
    …o capybara 2.1.0
    
    Focused within to p within the #content div
    
    Focused within for message test from acceptance/alps/message-search
Commits on May 27, 2013
  1. @carols10cents
  2. @carols10cents
Commits on Mar 10, 2013
  1. @wilkie

    Adds rels for user profile links to followers, following, and updates.

    wilkie authored
    According to ALPS, the following rels are used on <a> tags:
    
    messages-me: Applied to an A tag. A reference to a list representation
    of all the messages posted by the designated user.
    
    users-friends: Applied to an A tag. A reference to list representation
    of the designated user's friend users.
    
    users-followers: Applied to an A tag. A reference to list representation
    of the users who follow the designated user.
Commits on Mar 3, 2013
  1. @wilkie

    Fixes the tests so that they can execute on their own.

    wilkie authored
    Speed benchmarks:
    
    ```
    $ rake
    test:file[test/services/subscriber_to_feed_data_converter_test.rb]
    
    6 tests, 1 assertions, 1 failures, 5 errors, 0 skips
    ```
    
    ```
    $ rake
    test:file[test/services/subscriber_to_feed_data_converter_test.rb]
    
    Finished tests in 0.005167s, 1161.2156 tests/s, 2128.8953 assertions/s.
    
    ```
    
    Fair enough.
Commits on Mar 2, 2013
  1. @wilkie

    Removing TestHelper from FeedService tests.

    wilkie authored
    This removes the overhead imprint.
    
    Tests run at quick speed:
    
    $ rake test:file[test/services/feed_service_test.rb]
    test/services/feed_service_test.rb
    Rack::File headers parameter replaces cache_control after Rack 1.5.
    Run options: --seed 41627
    
    .....
    
    Finished tests in 0.015902s, 314.4225 tests/s, 377.3070 assertions/s.
  2. @wilkie

    Fixes FeedService tests to actually test things.

    wilkie authored
    The original tests stubbed the private methods which means they mostly
    just tested ruby's precedence order. :) Private methods are forced
    integrations... we have to allow them to operate in turn in order to
    assess behavior.
Commits on Feb 19, 2013
  1. @wilkie
Commits on Dec 27, 2012
  1. @carols10cents
  2. @carols10cents

    Merge remote-tracking branch 'origin/feature/change_username'

    carols10cents authored
    Conflicts:
    	test/models/user_test.rb
  3. @carols10cents

    Merge remote-tracking branch 'origin/test_cleanup'

    carols10cents authored
    Conflicts:
    	test/models/author_test.rb
  4. @carols10cents

    Merge remote-tracking branch 'origin/issue_698'

    carols10cents authored
    Conflicts:
    	test/lib/converts_subscriber_to_feed_data_test.rb
    	test/lib/finds_or_creates_feeds_test.rb
    	test/lib/finger_test.rb
  5. @carols10cents
Commits on Dec 2, 2012
  1. @carols10cents
  2. @carols10cents
Commits on Nov 26, 2012
  1. @carols10cents
  2. @carols10cents
  3. @carols10cents
  4. @carols10cents
Commits on Nov 24, 2012
  1. @carols10cents

    Fixes Issue #548 and #731. Handles cases where author is nil and that…

    carols10cents authored
    … causes errors in the view.
    
    I don't know how update authors get to be nil, but here we are.
Commits on Nov 22, 2012
  1. @carols10cents

    Since an unsuccessful profile update shouldn't ping hubs, there's no …

    carols10cents authored
    …need to use a VCR cassette in tests of unsuccessful profile updates
  2. @carols10cents

    Show multiple error messages when there are multiple errors saving a …

    carols10cents authored
    …profile edit
    
    Reuse the errors partial from the signup process; make the message more general.
  3. @wilkie @carols10cents

    Updates name of edit profile action.

    wilkie authored carols10cents committed
    The old name made its destructive behavior unclear and its mutation.
    This now has the common update_ prefix and a bang to indicate this. It
    is far more instructive than edit_user_profile since edit is an action
    and what is that?! It's update everywhere else! Who wrote this, an
    alien? :D :D :D
  4. @wilkie @carols10cents

    Adds functionality to change your username.

    wilkie authored carols10cents committed
    This functionality affects the User controller and model and view.
    
    In the model, I have replaced the behavior of the edit_user_profile
    badness to just add freaking errors to self whenever something is
    invalid instead of reporting a string since those errors contain
    consistent error messages anyway. It does not return. I will reflect
    this in another commit by changing the name to something more
    appropriate.
    
    Which means in the model, I have added messages to validations that for
    some reason did not have one before. We should put those strings all in
    one place eventually for sanity.
    
    In the controller, I updated the, um, update action to look for errors
    like a normal controller action would and respond naturally. Some
    wonkiness occurs.
    
    This wonkiness is a result of trying to change the field that the
    current url is built from. Therefore, let's use the canonical user,
    current_user, whenever possible. When redirecting, we have changed the
    canonical user, therefore use @user to generate urls.
    
    That wonkiness is in the view. Here, @user is the current image of the
    user and current_user is the true user (or preimage, I guess.) So, using
    current_user where (honestly, you would expect current_user anyway) you
    want to use the stable values and @user when you want the changed fields
    is what I've done.
    
    Tests:
    
    Updates tests to reflect changes in error messages.
    
    Adds four acceptance tests to edit_profile_test:
    
    * it updates your username (check that a username can simply be changed)
    * it does not update your username if the chosen username exists (make
        sure that you cannot steal somebody else's name)
    * it redirects to your new name when you change your username (the
        redirect should take you to your profile, which has a different url
        now)
    * it does not allow you to change your username to something invalid (do
        not allow special characters in your name)
    
    Adds one unit test:
    
    * username can be changed (checks that the edit_user_profile method,
        which will become update_profile! actually updates the username with
        the given parameter)
  5. @wilkie

    Merge pull request #724 from carols10cents/issue_532

    wilkie authored
    Don't even try authenticating by checking hashed_password if there isn't one-- just fail.
    
    Fixes #532.
  6. @gavinlaking @carols10cents

    Improve code style

    gavinlaking authored carols10cents committed
    - organized schema, associations, validations, and callbacks in models
    - whitespace changes for clarity
  7. @gavinlaking @carols10cents
Commits on Nov 21, 2012
  1. @wilkie

    Merge pull request #726 from carols10cents/unused_arguments

    wilkie authored
    User#timeline and User#at_replies don't use the arguments they're being ...
Something went wrong with that request. Please try again.