Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a small, yet major typo. #554

Merged
merged 1 commit into from Jul 31, 2012
Merged

Conversation

Valarissa
Copy link
Contributor

:dependant => :destroy is not a valid association parameter. :dependent => :destroy, however, is legit. This may have left us with a huge number of orphaned authorizations.

The authorizations on rstat.us proper should probably be checked to see if there have been any orphans left from account deletions.

Furthermore, it may actually be affecting the random test failures on travis... maybe.

@steveklabnik
Copy link
Contributor

Oh man, did I do this?

@Valarissa
Copy link
Contributor Author

46c227a » steveklabnik
2011-03-13 let's syndicate to twitter, shall we? 70 many :authorizations, :dependant => :destroy

Your name... and commit says yes, that was you. :)

@travisbot
Copy link

This pull request passes (merged a613450 into a3f66a5).

@steveklabnik
Copy link
Contributor

fffuuuuuu

steveklabnik added a commit that referenced this pull request Jul 31, 2012
Fixed a small, yet major typo.
@steveklabnik steveklabnik merged commit 8015a10 into hotsh:master Jul 31, 2012
@jaimeiniesta
Copy link

That's why I think it's a good idea to test cascade deletions, validations, etc.

You're not testing that Rails knows how to do this, you're testing that you set this up properly in your models.

@carols10cents
Copy link
Contributor

I still have no idea what causes the random travis failures that are skips right now... if it was this, shouldn't they fail locally too? Those tests never fail locally for me.

@Valarissa
Copy link
Contributor Author

How many people here use Linux? I know we encountered something at Pikimal where our ci servers would run tests in a different order than Mac OSX due to differences in the file system crawling.

@carols10cents
Copy link
Contributor

not it. minitest runs tests in random order by default though.... but i dont know what it does with nested describes? sounds plausible, i'm just not sure how likely.

@Valarissa
Copy link
Contributor Author

I'm seeing the passed tests at the same point every run... which is odd because they definitely have different seeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants