Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Ignore vendor/bundle folder #681

Merged
merged 1 commit into from

4 participants

@tlatsas
Collaborator

Bundler installs gems in vendor/bundle by default when using the
--deployment switch.

@tlatsas tlatsas Ignore vendor/bundle folder.
Bundler installs gems in vendor/bundle by default when using the
`--deployment` switch.

[ci skip]
bb0ced1
@wilkie
Owner

AHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH.

ok. but the next time I meet a bundler dev in person, they get a giant slap in the face.

@wilkie wilkie merged commit 2e90467 into from
@wilkie
Owner

Thanks! :)

@steveklabnik

Ehhh this is already merged, and I don't want to fight about it, but you really shouldn't be committing after doing a bundle --deployment, so I don't think this is needed.

@wilkie
Owner

#677 (comment)

I am following by example, oh great and very vocal spiritual leader. :)

@steveklabnik

:)

@wilkie
Owner

I defer to my previous comments about not being very happy about it. :D

@tlatsas
Collaborator

I thought it would be a good idea, because apart from the --deployment switch, the bundler docs say:

Install your dependencies, even gems that are already installed to your system gems,
to a location other than your system's gem repository.
In this case, install them to vendor/bundle. 

Sorry if this technique isn't widely used.

@steveklabnik

It's all good! Having an extra line in our .gitignore isn't a big deal.

Generally, people push their code to their servers, then run --deployment on the server. So you'd never be committing the bundle.

@carols10cents

@tlatsas - I just added you to our team of committers since this pull request was accepted! Please read the section in the readme about being a committer and let me know if you have any questions :heart::heart:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 11, 2012
  1. @tlatsas

    Ignore vendor/bundle folder.

    tlatsas authored
    Bundler installs gems in vendor/bundle by default when using the
    `--deployment` switch.
    
    [ci skip]
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  .gitignore
View
1  .gitignore
@@ -14,3 +14,4 @@ log/*.log*
capybara*
.DS_Store
.bundle
+vendor/bundle
Something went wrong with that request. Please try again.