Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Bugfix/therubyracer only on linux #742

Merged
merged 2 commits into from Feb 19, 2013

Conversation

Projects
None yet
3 participants
Contributor

wilkie commented Feb 19, 2013

Since @steveklabnik suggests therubyracer in the Gemfile causes rstat.us not to bundle on OS X, I will simply remove it as a dependency on OS X and Windows where it is not necessary anyway.

However, I can confirm that on my Linux machine, not having therubyracer will indeed cause rstat.us to not be able to generate assets. It fails when I comment it out... works when I remove the comment and bundle. It is still necessary.

This makes sense. You need a js engine to use coffeescript, etc. On OS X, it uses the one provided with Safari. On Windows, the one used for IE can be used. On Linux, however, it does not have a guaranteed engine installed. And since rstat.us should be viable for all deployment opportunities, this means it will find itself on bare Linux environments. It should not hurt to have therubyracer installed even if libv8 is installed through different means on Linux.

Therefore, the Gemfile contains a condition that checks the platform for OS specific tags. It only blacklists the two OSes, so it should be rather conservative.

Contributor

jrgifford commented Feb 19, 2013

I install nodejs on my linux boxes and it works fine - I'm not sure why
people still use therubyracer.

James Gifford
cell: 2162238574

On Mon, Feb 18, 2013 at 8:58 PM, Dave Wilkinson II <notifications@github.com

wrote:

Since @steveklabnik https://github.com/steveklabnik suggests
therubyracer in the Gemfile causes rstat.us not to bundle on OS X, I will
simply remove it as a dependency on OS X and Windows where it is not
necessary anyway.

However, I can confirm that on my Linux machine, not having therubyracer
will indeed cause rstat.us to not be able to generate assets. It fails
when I comment it out... works when I remove the comment and bundle. It is
still necessary.

This makes sense. You need a js engine to use coffeescript, etc. On OS X,
it uses the one provided with Safari. On Windows, the one used for IE can
be used. On Linux, however, it does not have a guaranteed engine installed.
And since rstat.us should be viable for all deployment opportunities,
this means it will find itself on bare Linux environments. It should not
hurt to have therubyracer installed even if libv8 is installed through
different means on Linux.

Therefore, the Gemfile contains a condition that checks the platform for
OS specific tags. It only blacklists the two OSes, so it should be rather

conservative.

You can merge this Pull Request by running

git pull https://github.com/wilkie/rstat.us bugfix/therubyracer-only-on-linux

Or view, comment on, or merge it at:

#742
Commit Summary

  • Puts therubyracer in asset group and only install if on linux.
  • Updates therubyracer.

File Changes

Patch Links:

@steveklabnik steveklabnik added a commit that referenced this pull request Feb 19, 2013

@steveklabnik steveklabnik Merge pull request #742 from wilkie/bugfix/therubyracer-only-on-linux
Bugfix/therubyracer only on linux
6b6d6d7

@steveklabnik steveklabnik merged commit 6b6d6d7 into hotsh:master Feb 19, 2013

1 check passed

default The Travis build passed
Details
Contributor

steveklabnik commented Feb 19, 2013

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment