Skip to content

refactor Users#reset_password_create action to reduce complexity #792

Merged
merged 1 commit into from Oct 29, 2013

3 participants

@hindenbug

Extract password reset logic in PasswordService class.

Any feedback on this? 😄

@hindenbug hindenbug refactor Users#reset_password_create action to reduce complexity
Extract password reset logic in PasswordService class.
1ad327e
@colindean

I didn't test it myself, but it looks good to me.

@wilkie
wilkie commented Oct 29, 2013

The recent Travis environment change hiccuped on our Gemfile again. Nothing in your code should be invalid for that ruby version though. Looks great!

Aside: The strings embedded in that lib class remind me that we still need a solution for issue #568

Thank you for this! Refactors are greatly appreciated! ❤️

@wilkie wilkie merged commit 5e6b338 into hotsh:master Oct 29, 2013

1 check failed

Details default The Travis CI build could not complete due to an error
@hindenbug

@wilkie @colindean Thanks for the review comments :)
Totally agree, those "string" messages look ugly sitting there 💣

@wilkie
wilkie commented Oct 29, 2013

Something like gettext or the i18n gem would make it uglier, but it is one of those useful types of ugly code. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.