From 9c0fd71eac1f2590b5840f1566d5a02d37ef87aa Mon Sep 17 00:00:00 2001 From: jcpascual <91902144+jcpascual@users.noreply.github.com> Date: Sat, 9 Apr 2022 13:40:33 -0400 Subject: [PATCH] log_controller_test_case: Fix deepEqual returning true for primitive types (#533) --- src/tests/cases/log_controller_test_case.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/tests/cases/log_controller_test_case.ts b/src/tests/cases/log_controller_test_case.ts index d1a44ec6..fceb4b4d 100644 --- a/src/tests/cases/log_controller_test_case.ts +++ b/src/tests/cases/log_controller_test_case.ts @@ -37,7 +37,7 @@ function slice(object: any, keys: string[]): any { function deepEqual(obj1: any, obj2: any): boolean { if (obj1 === obj2) { return true - } else { + } else if (typeof obj1 === "object" && typeof obj2 === "object") { if (Object.keys(obj1).length !== Object.keys(obj2).length) { return false } for (var prop in obj1) { if (!deepEqual(obj1[prop], obj2[prop])) { @@ -45,5 +45,7 @@ function deepEqual(obj1: any, obj2: any): boolean { } } return true + } else { + return false } }