Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start when the DOM is interactive #131

Merged
merged 7 commits into from Mar 27, 2018
Merged

Start when the DOM is interactive #131

merged 7 commits into from Mar 27, 2018

Conversation

@javan
Copy link
Contributor

@javan javan commented Mar 22, 2018

Alternate title: Defer connecting controllers until the DOM is ready.

Fixes #97

@javan javan added this to the 1.1 milestone Mar 22, 2018
@david-a-wheeler
Copy link

@david-a-wheeler david-a-wheeler commented Mar 22, 2018

Does this PR work with turbolinks? Turbolinks rewrites pages, so its idea of "ready" is different than many other systems.

@javan javan changed the title Start element observers when the DOM is interactive Start when the DOM is interactive Mar 23, 2018
@javan javan force-pushed the async-start branch 2 times, most recently from 4e3a266 to 6a29dcd Mar 23, 2018
@javan javan force-pushed the async-start branch from 6a29dcd to 642ad1e Mar 27, 2018
@javan javan merged commit 6b15e02 into master Mar 27, 2018
1 check passed
1 check passed
ci/circleci Your tests passed on CircleCI!
Details
@javan javan deleted the async-start branch Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants