Include url in turbo:before-fetch-request event (#289)

* Avoid race between visit tests

TurboDriveTestCase maintains a eventLogChannel that acts as a cursor
for the page's window.eventLogs array. Before every test the
eventLogChannel is drained by reading all events and its internal
index (cursor) is updated accordingly.

The race was happening when we changed the page location and not
blocking on it: the eventLogChannel was draining the previous page
bumping its internal index. After the page was reload that index was
out of sync since the new page had an new, empty eventLogs array.

Order of events
 * async location change
 * draining eventLogChannel on the previous page
 * actual location change
 * eventLogChannel is out-of-sync

This is was fixed as part of #289

* Include url in `turbo:before-fetch-request` event

Author: ctrochalakis

src/http/fetch_request.ts

@@ -132,7 +132,7 @@ export class FetchRequest {
 
   private async allowRequestToBeIntercepted(fetchOptions: RequestInit) {
     const requestInterception = new Promise(resolve => this.resolveRequestPromise = resolve)
-    const event = dispatch("turbo:before-fetch-request", { cancelable: true, detail: { fetchOptions, resume: this.resolveRequestPromise } })
+    const event = dispatch("turbo:before-fetch-request", { cancelable: true, detail: { fetchOptions, url: this.url.href, resume: this.resolveRequestPromise } })
     if (event.defaultPrevented) await requestInterception
   }
 }

src/tests/functional/visit_tests.ts

@@ -71,6 +71,14 @@ export class VisitTests extends TurboDriveTestCase {
     this.assert(await this.changedBody)
   }
 
+  async "test turbo:before-fetch-request event.detail"() {
+    await this.clickSelector("#same-origin-link")
+    const { url, fetchOptions } = await this.nextEventNamed("turbo:before-fetch-request")
+
+    this.assert.equal(fetchOptions.method, "GET")
+    this.assert.include(url, "/src/tests/fixtures/one.html")
+  }
+
   async visitLocation(location: string) {
     this.remote.execute((location: string) => window.Turbo.visit(location), [location])
   }